Give Timer a virtual destructor as it's deleted polymorphically.

Found by clang: ..\..\third_party\angle\src\common/angleutils.h(66,5) : error: delete called on 'Timer' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] delete resource; ^ ..\..\third_party\angle\src\tests\perf_tests\ANGLEPerfTest.cpp(26,5) : note: in instantiation of function template specialization 'SafeDelete<Timer>' requested here SafeDelete(mTimer); ^ BUG=chromium:82385 Change-Id: I69033b1802b5dffbdf2d80889aca7019d710d481 Reviewed-on: https://chromium-review.googlesource.com/264061Reviewed-by: Geoff Lang <geofflang@chromium.org> Tested-by: Geoff Lang <geofflang@chromium.org>

Give Timer a virtual destructor as it's deleted polymorphically.
51a1db16 · Nico Weber · Geoff Lang · 711d8663 · 51a1db16
Commit 51a1db16 authored Apr 06, 2015 by Nico Weber Committed by Geoff Lang Apr 06, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

Timer.h util/Timer.h +1 -0

No files found.
--- a/util/Timer.h
+++ b/util/Timer.h
@@ -10,6 +10,7 @@
 class Timer
 {
  public:
+    virtual ~Timer() {}
    virtual void start() = 0;
    virtual void stop() = 0;
    virtual double getElapsedTime() const = 0;