Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
angle
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
angle
Commits
51a53c7b
Commit
51a53c7b
authored
Jun 19, 2013
by
Jamie Madill
Committed by
Shannon Woods
Jul 19, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Properly report error when layout qualifiers are specified outside uniform blocks.
TRAC #23357 Signed-off-by: Shannon Woods Signed-off-by: Geoff Lang Authored-by: Jamie Madill
parent
fd39655d
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
ParseHelper.cpp
src/compiler/ParseHelper.cpp
+5
-5
No files found.
src/compiler/ParseHelper.cpp
View file @
51a53c7b
...
...
@@ -976,18 +976,18 @@ bool TParseContext::singleDeclarationErrorCheck(TPublicType &publicType, TSource
if
(
layoutQualifier
.
matrixPacking
!=
EmpUnspecified
)
{
error
(
identifierLocation
,
"layout qualifier"
,
getMatrixPackingString
(
layoutQualifier
.
matrixPacking
),
"only valid for interface blocks"
);
return
fals
e
;
return
tru
e
;
}
if
(
layoutQualifier
.
blockStorage
!=
EbsUnspecified
)
{
error
(
identifierLocation
,
"layout qualifier"
,
getBlockStorageString
(
layoutQualifier
.
blockStorage
),
"only valid for interface blocks"
);
return
fals
e
;
return
tru
e
;
}
if
(
publicType
.
qualifier
!=
EvqVertexInput
&&
publicType
.
qualifier
!=
EvqFragmentOutput
&&
layoutLocationErrorCheck
(
identifierLocation
,
publicType
.
layoutQualifier
))
{
return
fals
e
;
return
tru
e
;
}
return
false
;
...
...
@@ -1226,7 +1226,7 @@ TIntermAggregate* TParseContext::parseSingleDeclaration(TPublicType &publicType,
if
(
identifier
!=
""
)
{
if
(
s
tructQualifierErrorCheck
(
identifierLocation
,
publicType
))
if
(
s
ingleDeclarationErrorCheck
(
publicType
,
identifierLocation
,
identifier
))
recover
();
// this error check can mutate the type
...
...
@@ -1249,7 +1249,7 @@ TIntermAggregate* TParseContext::parseSingleDeclaration(TPublicType &publicType,
TIntermAggregate
*
TParseContext
::
parseSingleArrayDeclaration
(
TPublicType
&
publicType
,
TSourceLoc
identifierLocation
,
const
TString
&
identifier
,
TSourceLoc
indexLocation
,
TIntermTyped
*
indexExpression
)
{
if
(
s
tructQualifierErrorCheck
(
identifierLocation
,
publicType
))
if
(
s
ingleDeclarationErrorCheck
(
publicType
,
identifierLocation
,
identifier
))
recover
();
// this error check can mutate the type
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment