Skip to content

A
angle
Commit 52f77eed by Tim Van Patten Committed by Commit Bot
Options

Suppress BestPractices-vkCreateDevice-specialuse-extension

Suppress the VVL warning: UNASSIGNED-BestPractices-vkCreateDevice-specialuse-extension ANGLE uses the extension to match OpenGL ES line rasterization behavior, so this warning doesn't apply and is being suppressed. Bug: angleproject:5336 Change-Id: I2f0e086a7ff392e13b6a1da0a55b0e1b81953b2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533437Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent 3c3edc3b
Showing with 7 additions and 11 deletions
src/libANGLE/renderer/vulkan/RendererVk.cpp
...@@ -131,19 +131,15 @@ constexpr const char *kSkippedMessages[] = { ...@@ -131,19 +131,15 @@ constexpr const char *kSkippedMessages[] = {
"VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428", "VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428",
// http://anglebug.com/4063 // http://anglebug.com/4063
"VUID-VkDeviceCreateInfo-pNext-pNext", "VUID-VkDeviceCreateInfo-pNext-pNext",
"VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext", "VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext", "VUID_Undefined",
"VUID_Undefined",
// https://issuetracker.google.com/issues/159493191 // https://issuetracker.google.com/issues/159493191
"VUID-vkCmdDraw-None-02690", "VUID-vkCmdDraw-None-02690", "VUID-vkCmdDrawIndexed-None-02690",
"VUID-vkCmdDrawIndexed-None-02690",
// http://anglebug.com/4975 // http://anglebug.com/4975
"VUID-vkCmdDraw-None-02687", "VUID-vkCmdDraw-None-02687", "VUID-vkCmdDrawIndexed-None-02687",
"VUID-vkCmdDrawIndexed-None-02687",
// Best Practices Skips https://issuetracker.google.com/issues/166641492 // Best Practices Skips https://issuetracker.google.com/issues/166641492
// https://issuetracker.google.com/issues/166793850 // https://issuetracker.google.com/issues/166793850
"UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset", "UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset",
"UNASSIGNED-BestPractices-pipeline-stage-flags", "UNASSIGNED-BestPractices-pipeline-stage-flags", "UNASSIGNED-BestPractices-Error-Result",
"UNASSIGNED-BestPractices-Error-Result",
"UNASSIGNED-BestPractices-vkAllocateMemory-small-allocation", "UNASSIGNED-BestPractices-vkAllocateMemory-small-allocation",
"UNASSIGNED-BestPractices-vkBindMemory-small-dedicated-allocation", "UNASSIGNED-BestPractices-vkBindMemory-small-dedicated-allocation",
"UNASSIGNED-BestPractices-vkAllocateMemory-too-many-objects", "UNASSIGNED-BestPractices-vkAllocateMemory-too-many-objects",
...@@ -157,11 +153,11 @@ constexpr const char *kSkippedMessages[] = { ...@@ -157,11 +153,11 @@ constexpr const char *kSkippedMessages[] = {
// http://anglebug.com/5027 // http://anglebug.com/5027
"UNASSIGNED-CoreValidation-Shader-PushConstantOutOfRange", "UNASSIGNED-CoreValidation-Shader-PushConstantOutOfRange",
// http://anglebug.com/5304 // http://anglebug.com/5304
"VUID-vkCmdDraw-magFilter-04553", "VUID-vkCmdDraw-magFilter-04553", "VUID-vkCmdDrawIndexed-magFilter-04553",
"VUID-vkCmdDrawIndexed-magFilter-04553",
// http://anglebug.com/5309 // http://anglebug.com/5309
"VUID-VkImageViewCreateInfo-usage-02652", "VUID-VkImageViewCreateInfo-usage-02652",
}; // http://anglebug.com/5336
"UNASSIGNED-BestPractices-vkCreateDevice-specialuse-extension"};
// Suppress validation errors that are known // Suppress validation errors that are known
// return "true" if given code/prefix/message is known, else return "false" // return "true" if given code/prefix/message is known, else return "false"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment