Fix GetUniform validation.

We were missing a check for an out-of-bounds Uniform, which could cause us to miss an error and also give assertion failures. BUG=angle:571 Change-Id: I844658a82ce13ea179a2358a202733c54bc2c0c7 Reviewed-on: https://chromium-review.googlesource.com/212934Tested-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

Fix GetUniform validation.
549c7fdf · Jamie Madill · 78f41805 · 549c7fdf
Commit 549c7fdf authored Aug 25, 2014 by Jamie Madill
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

validationES.cpp src/libGLESv2/validationES.cpp +5 -0

No files found.
--- a/src/libGLESv2/validationES.cpp
+++ b/src/libGLESv2/validationES.cpp
@@ -1691,6 +1691,11 @@ bool ValidateGetUniformBase(const gl::Context *context, GLuint program, GLint lo
        return gl::error(GL_INVALID_OPERATION, false);
    }
+    if (!programBinary->isValidUniformLocation(location))
+    {
+        return gl::error(GL_INVALID_OPERATION, false);
+    }
    return true;
 }