Fix texture and buffer data bugs in tests found by ASAN.

src/tests/gl_tests/CopyTexture3DTest.cpp

@@ -324,7 +324,7 @@ TEST_P(Texture3DCopy, CopyFromMipmap)
 {
     ANGLE_SKIP_TEST_IF(!checkExtensions());
 
-    std::vector<GLColor> texDataGreen(2u * 2u * 2u, GLColor::green);
+    std::vector<GLColor> texDataGreen(4u * 4u * 4u, GLColor::green);
 
     glBindTexture(GL_TEXTURE_3D, sourceTexture.get());
     glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA, 4, 4, 4, 0, GL_RGBA, GL_UNSIGNED_BYTE,

src/tests/gl_tests/MipmapTest.cpp

@@ -1220,8 +1220,10 @@ TEST_P(MipmapTestES3, BaseLevelTextureBug)
     // Probably not Intel.
     ANGLE_SKIP_TEST_IF(IsOSX() && (IsNVIDIA() || IsIntel()));
 
+    std::vector<GLColor> texDataRed(2u * 2u, GLColor::red);
+
     glBindTexture(GL_TEXTURE_2D, mTexture);
-    glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, &GLColor::red);
+    glTexImage2D(GL_TEXTURE_2D, 2, GL_RGBA, 2, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, texDataRed.data());
     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_BASE_LEVEL, 2);
     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);

src/tests/gl_tests/StateChangeTest.cpp

@@ -3029,11 +3029,9 @@ void main()
     glBindBufferBase(GL_TRANSFORM_FEEDBACK_BUFFER, 0, transformFeedbackBuffer);
 
     // Set up uniform buffer.
-    std::vector<GLColor32F> redData(1, kFloatGreen);
-
     GLBuffer uniformBuffer;
     glBindBuffer(GL_UNIFORM_BUFFER, uniformBuffer);
-    glBufferData(GL_UNIFORM_BUFFER, 128, &kFloatGreen.R, GL_STATIC_DRAW);
+    glBufferData(GL_UNIFORM_BUFFER, sizeof(GLColor32F), &kFloatGreen.R, GL_STATIC_DRAW);
     glBindBufferBase(GL_UNIFORM_BUFFER, 0, uniformBuffer);
 
     ASSERT_GL_NO_ERROR();

src/tests/gl_tests/TimerQueriesTest.cpp

@@ -186,7 +186,7 @@ TEST_P(TimerQueriesTest, TimeElapsedTextureTest)
     // Skip test if the number of bits is 0
     ANGLE_SKIP_TEST_IF(!queryTimeElapsedBits);
 
-    GLubyte pixels[] = {0, 0, 0, 255, 255, 255, 255, 255, 255, 0, 0, 0};
+    std::vector<GLColor> texData{GLColor::black, GLColor::white, GLColor::white, GLColor::black};
 
     // Query and texture initialization
     GLuint texture;
@@ -198,7 +198,7 @@ TEST_P(TimerQueriesTest, TimeElapsedTextureTest)
     glBeginQueryEXT(GL_TIME_ELAPSED_EXT, query);
     glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);
     glBindTexture(GL_TEXTURE_2D, texture);
-    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, 2, 2, 0, GL_RGB, GL_UNSIGNED_BYTE, pixels);
+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, 2, 2, 0, GL_RGB, GL_UNSIGNED_BYTE, texData.data());
     glGenerateMipmap(GL_TEXTURE_2D);
     glFinish();
     glEndQueryEXT(GL_TIME_ELAPSED_EXT);

src/tests/gl_tests/WebGLCompatibilityTest.cpp

@@ -4000,7 +4000,7 @@ TEST_P(WebGLCompatibilityTest, GenerateMipmapUnsizedFloatingPointTexture)
         kFloatGreen,
         kFloatBlue,
     };
-    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 4, 4, 0, GL_RGBA, GL_FLOAT, data);
+    glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 2, 2, 0, GL_RGBA, GL_FLOAT, data);
     ASSERT_GL_NO_ERROR();
 
     glGenerateMipmap(GL_TEXTURE_2D);