Skip to content

A
angle
Commit 593706bc by Jamie Madill Committed by Commit Bot
Options

Test Runner: Increase default timeouts.

In particular the Debug timeout was not generous enough. Increase the test timeout to 20 seconds in Release and 60 seconds in Debug. Increase the batch timeout to 240 seconds in Release and 600 seconds in Debug. Bug: angleproject:3162 Change-Id: I0bd0ea18cb5cdab005143b8deed9500d9d2e8ea1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047415 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org>
parent caf7becc
Showing with 15 additions and 6 deletions
src/tests/test_utils/runner/TestSuite.cpp
......@@ -32,11 +32,20 @@ namespace angle
{
namespace
{
constexpr char kTestTimeoutArg[] = "--test-timeout=";
constexpr char kFilterFileArg[] = "--filter-file=";
constexpr char kResultFileArg[] = "--results-file=";
constexpr int kDefaultTestTimeout = 10;
constexpr int kDefaultBatchSize = 1000;
constexpr char kTestTimeoutArg[] = "--test-timeout=";
constexpr char kFilterFileArg[] = "--filter-file=";
constexpr char kResultFileArg[] = "--results-file=";
#if defined(NDEBUG)
constexpr int kDefaultTestTimeout = 20;
#else
constexpr int kDefaultTestTimeout = 60;
#endif
#if defined(NDEBUG)
constexpr int kDefaultBatchTimeout = 240;
#else
constexpr int kDefaultBatchTimeout = 600;
#endif
constexpr int kDefaultBatchSize = 1000;
const char *ParseFlagValue(const char *flag, const char *argument)
{
......@@ -645,7 +654,7 @@ TestSuite::TestSuite(int *argc, char **argv)
mTotalResultCount(0),
mMaxProcesses(NumberOfProcessors()),
mTestTimeout(kDefaultTestTimeout),
mBatchTimeout(60)
mBatchTimeout(kDefaultBatchTimeout)
{
bool hasFilter = false;
bool alsoRunDisabledTests = false;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment