Skip to content

A
angle
Commit 5abc0c56 by Qin Jiajia Committed by Commit Bot
Options

Fix failures that alpha channel is not correct

Previously, the alpha channel was not set which resulted the intended swapchain buffer format is B8G8R8X8_UNORM. It means that the format supports 8 bits for each color channel and 8 bits unused. However, in our test case, we expect to compare the alpha channel. So we should set alpha channel explicitly. Bug: angleproject:4575 Bug: angleproject:4576 Change-Id: Ic26ee81a6a34dc44d0ae32e3dc463e9afa16e05c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237189 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent 74b33834
Showing with 2 additions and 5 deletions
src/tests/gl_tests/DrawElementsTest.cpp
...@@ -24,6 +24,8 @@ class DrawElementsTest : public ANGLETest ...@@ -24,6 +24,8 @@ class DrawElementsTest : public ANGLETest
setWindowHeight(64); setWindowHeight(64);
setConfigRedBits(8); setConfigRedBits(8);
setConfigGreenBits(8); setConfigGreenBits(8);
setConfigBlueBits(8);
setConfigAlphaBits(8);
} }
~DrawElementsTest() ~DrawElementsTest()
...@@ -111,8 +113,6 @@ TEST_P(DrawElementsTest, ClientSideNullptrArrayZeroCount) ...@@ -111,8 +113,6 @@ TEST_P(DrawElementsTest, ClientSideNullptrArrayZeroCount)
// deleting the applied index buffer. // deleting the applied index buffer.
TEST_P(DrawElementsTest, DeletingAfterStreamingIndexes) TEST_P(DrawElementsTest, DeletingAfterStreamingIndexes)
{ {
// http://anglebug.com/4575 - Test skipped on D3D11 (alpha channel not correct)
ANGLE_SKIP_TEST_IF(IsWindows() && IsD3D11());
// Init program // Init program
constexpr char kVS[] = constexpr char kVS[] =
"attribute vec2 position;\n" "attribute vec2 position;\n"
...@@ -239,9 +239,6 @@ TEST_P(DrawElementsTest, DeletingAfterStreamingIndexes) ...@@ -239,9 +239,6 @@ TEST_P(DrawElementsTest, DeletingAfterStreamingIndexes)
// Test drawing to part of the indices in an index buffer, and then all of them. // Test drawing to part of the indices in an index buffer, and then all of them.
TEST_P(DrawElementsTest, PartOfIndexBufferThenAll) TEST_P(DrawElementsTest, PartOfIndexBufferThenAll)
{ {
// http://anglebug.com/4575 - Test skipped on D3D11 (alpha channel not correct)
// http://anglebug.com/4576 - Test skipped on SwiftShader (alpha channel not drawn)
ANGLE_SKIP_TEST_IF(IsWindows() && (IsD3D11() || isSwiftshader()));
// Init program // Init program
constexpr char kVS[] = constexpr char kVS[] =
"attribute vec2 position;\n" "attribute vec2 position;\n"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment