Add gyp deprecation warning.

gyp_angle now prints a warning every time it is run. All targets print the same warning as one of their build steps. The DEPS change updates gypi_to_gn so it doesn't choke on files with 'target_defaults' sections. BUG=angleproject:1569 Change-Id: Ibdf277fcc14cf4ebc7b7db78270210752cd8ef9d Reviewed-on: https://chromium-review.googlesource.com/711155Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Add gyp deprecation warning.
5b1180df · Frank Henigman · Commit Bot · 0e74e059 · 5b1180df · 5b1180df
Commit 5b1180df authored Oct 10, 2017 by Frank Henigman Committed by Commit Bot Dec 18, 2017
7 changed files
--- a/DEPS
+++ b/DEPS
@@ -6,7 +6,7 @@ vars = {
 deps = {

  'build':
-    Var('chromium_git') + '/chromium/src/build.git' + '@' + '8a1537f019e55807420ae76c62e4ce8f56fedca1',
+    Var('chromium_git') + '/chromium/src/build.git' + '@' + '2f3b6e8ce9e783b2a09496d70eef2974506a41c8',

  'buildtools':
    Var('chromium_git') + '/chromium/buildtools.git' + '@' + '461b345a815c1c745ac0534a6a4bd52d123abe68',

--- a/gyp/gyp_angle
+++ b/gyp/gyp_angle
@@ -65,6 +65,10 @@ def generateWinRTProjects(generate_args, generation_dir, msvs_version, app_type_
    gyp.main(args)

 if __name__ == '__main__':
+    print
+    print '* * * WARNING: GYP IS DEPRECATED * * *'
+    print 'See https://chromium.googlesource.com/angle/angle/+/master/doc/DevSetup.md for new build instructions.'
+    print
    print 'Updating projects from gyp files...'
    sys.stdout.flush()


--- a/gyp/warnings.gyp
+++ b/gyp/warnings.gyp
+# Copyright (c) 2017 The ANGLE Project Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+    'targets':
+    [
+        {
+            'target_name': 'gyp_deprecation',
+            'type': 'none',
+            'actions':
+            [
+                {
+                    'action_name': 'GYP deprecation warning',
+                    'message': ' * * * WARNING: GYP IS DEPRECATED * * *',
+                    'inputs': [],
+                    'outputs':
+                    [
+                        # this file is never created and should not exist so the action always runs
+                        'this_file_never_exists',
+                    ],
+                    'action':
+                    [
+                        'python', '-c', 'print "See https://chromium.googlesource.com/angle/angle/+/master/doc/DevSetup.md for new build instructions."',
+                    ],
+                },
+            ],
+        },
+    ],
+}
--- a/samples/samples.gyp
+++ b/samples/samples.gyp
@@ -3,6 +3,14 @@
 # found in the LICENSE file.

 {
+    'target_defaults':
+    {
+        'dependencies':
+        [
+            '../gyp/warnings.gyp:gyp_deprecation',
+        ],
+    },
+
    'targets':
    [
        {

--- a/src/angle.gyp
+++ b/src/angle.gyp
@@ -58,6 +58,14 @@
        'libEGL.gypi',
    ],

+    'target_defaults':
+    {
+        'dependencies':
+        [
+            '../gyp/warnings.gyp:gyp_deprecation',
+        ],
+    },
+
    'targets':
    [
        {

--- a/src/tests/tests.gyp
+++ b/src/tests/tests.gyp
@@ -41,6 +41,13 @@
            'third_party/rapidjson/include/rapidjson/msinttypes/stdint.h',
        ],
    },
+    'target_defaults':
+    {
+        'dependencies':
+        [
+            '../../gyp/warnings.gyp:gyp_deprecation',
+        ],
+    },
    'conditions':
    [
        # GoogleTest doesn't support WinRT

--- a/util/util.gyp
+++ b/util/util.gyp
@@ -88,6 +88,13 @@
            'android/third_party/android_native_app_glue.h',
        ],
    },
+    'target_defaults':
+    {
+        'dependencies':
+        [
+            '../gyp/warnings.gyp:gyp_deprecation',
+        ],
+    },
    'targets':
    [
        {