Revert "GN: Enable chromium_code config instead."

.gitattributes

@@ -6,4 +6,3 @@
 *.rc               eol=crlf
 **/compiled/*.h    eol=crlf
 *.sh               eol=lf
-*.gn               eol=lf

BUILD.gn

@@ -59,7 +59,10 @@ if (is_win) {
   }
 }
 
-angle_undefine_configs = [ "//build/config/compiler:default_include_dirs" ]
+angle_undefine_configs = [
+  "//build/config/compiler:chromium_code",
+  "//build/config/compiler:default_include_dirs",
+]
 
 component("translator") {
   sources = [
@@ -70,7 +73,10 @@ component("translator") {
   defines = [ "ANGLE_TRANSLATOR_IMPLEMENTATION" ]
 
   configs -= angle_undefine_configs
-  configs += [ ":internal_config" ]
+  configs += [
+    ":internal_config",
+    "//build/config/compiler:no_chromium_code",
+  ]
 
   public_deps = [
     ":translator_lib",
@@ -99,7 +105,10 @@ static_library("preprocessor") {
   sources = rebase_path(compiler_gypi.angle_preprocessor_sources, ".", "src")
 
   configs -= angle_undefine_configs
-  configs += [ ":internal_config" ]
+  configs += [
+    ":internal_config",
+    "//build/config/compiler:no_chromium_code",
+  ]
 }
 
 config("translator_static_config") {
@@ -130,6 +139,7 @@ static_library("angle_common") {
     ":angle_common_config",
     ":debug_annotations_config",
     ":internal_config",
+    "//build/config/compiler:no_chromium_code",
   ]
 
   public_deps = [
@@ -152,7 +162,10 @@ static_library("angle_image_util") {
   sources = rebase_path(gles_gypi.libangle_image_util_sources, ".", "src")
 
   configs -= angle_undefine_configs
-  configs += [ ":internal_config" ]
+  configs += [
+    ":internal_config",
+    "//build/config/compiler:no_chromium_code",
+  ]
 
   public_configs = [ ":angle_image_util_config" ]
 
@@ -186,6 +199,7 @@ static_library("translator_lib") {
   configs += [
     ":internal_config",
     ":translator_static_config",
+    "//build/config/compiler:no_chromium_code",
   ]
   public_configs = [ ":external_config" ]
 
@@ -197,12 +211,6 @@ static_library("translator_lib") {
   public_deps = [
     ":angle_common",
   ]
-
-  if (is_win) {
-    # Necessary to suppress some system header xtree warnigns in Release.
-    # For some reason this warning doesn't get triggered in Chromium
-    cflags = [ "/wd4718" ]
-  }
 }
 
 static_library("translator_static") {
@@ -216,7 +224,10 @@ static_library("translator_static") {
   }
 
   configs -= angle_undefine_configs
-  configs += [ ":internal_config" ]
+  configs += [
+    ":internal_config",
+    "//build/config/compiler:no_chromium_code",
+  ]
   public_configs = [ ":translator_static_config" ]
 
   public_deps = [
@@ -383,12 +394,12 @@ static_library("libANGLE") {
   }
 
   configs -= angle_undefine_configs
-
   configs += [
     ":commit_id_config",
     ":debug_annotations_config",
     ":libANGLE_config",
     ":internal_config",
+    "//build/config/compiler:no_chromium_code",
   ]
 
   if (is_win) {
@@ -402,10 +413,7 @@ config("shared_library_public_config") {
   if (is_mac && !is_component_build) {
     # Executable targets that depend on the shared libraries below need to have
     # the rpath setup in non-component build configurations.
-    ldflags = [
-      "-rpath",
-      "@executable_path/",
-    ]
+    ldflags = [ "-rpath", "@executable_path/" ]
   }
 }
 
@@ -418,10 +426,7 @@ shared_library("libGLESv2") {
   }
 
   if (is_mac && !is_component_build) {
-    ldflags = [
-      "-install_name",
-      "@rpath/${target_name}.dylib",
-    ]
+    ldflags = [ "-install_name", "@rpath/${target_name}.dylib" ]
     public_configs = [ ":shared_library_public_config" ]
   }
 
@@ -431,6 +436,7 @@ shared_library("libGLESv2") {
     ":commit_id_config",
     ":debug_annotations_config",
     ":libANGLE_config",
+    "//build/config/compiler:no_chromium_code",
   ]
 
   defines = [ "LIBGLESV2_IMPLEMENTATION" ]
@@ -449,10 +455,7 @@ shared_library("libEGL") {
   }
 
   if (is_mac && !is_component_build) {
-    ldflags = [
-      "-install_name",
-      "@rpath/${target_name}.dylib",
-    ]
+    ldflags = [ "-install_name", "@rpath/${target_name}.dylib" ]
     public_configs = [ ":shared_library_public_config" ]
   }
 
@@ -462,6 +465,7 @@ shared_library("libEGL") {
     ":commit_id_config",
     ":debug_annotations_config",
     ":libANGLE_config",
+    "//build/config/compiler:no_chromium_code",
   ]
 
   defines = [ "LIBEGL_IMPLEMENTATION" ]

build/common_defines.gypi

@@ -38,7 +38,11 @@
     [
         4100, # Unreferenced formal parameter. Not interesting.
         4127, # conditional expression is constant. Too noisy to be useful.
-        4718, # Recursive call has no side effects. Fires on xtree system header.
+
+        # TODO: 4702 doesn't fire on xtree in VS2015 (CTP6). We can remove C4702 after moving to VS2015.
+        4702, # Unreachable code. Should only fire on system header xtree.
+
+        4718, # Recursive call has no side effects. Fires on xtree too.
     ],
     'conditions':
     [

src/compiler/translator/Intermediate.cpp

@@ -503,4 +503,6 @@ TIntermTyped *TIntermediate::foldAggregateBuiltIn(TIntermAggregate *aggregate)
             // Constant folding not supported for the built-in.
             return nullptr;
     }
+
+    return nullptr;
 }

src/libANGLE/renderer/d3d/d3d11/renderer11_utils.cpp

@@ -797,7 +797,7 @@ static size_t GetMaximumVertexUniformBlocks(D3D_FEATURE_LEVEL featureLevel)
 
 static size_t GetReservedVertexOutputVectors(D3D_FEATURE_LEVEL featureLevel)
 {
-    // According to The OpenGL ES Shading Language specifications
+    // According to The OpenGL ES Shading Language specifications 
     // (Language Version 1.00 section 10.16, Language Version 3.10 section 12.21)
     // built-in special variables (e.g. gl_FragCoord, or gl_PointCoord)
     // which are statically used in the shader should be included in the variable packing algorithm.
@@ -820,6 +820,8 @@ static size_t GetReservedVertexOutputVectors(D3D_FEATURE_LEVEL featureLevel)
 
       default: UNREACHABLE();      return 0;
     }
+
+    return 1;
 }
 
 static size_t GetMaximumVertexOutputVectors(D3D_FEATURE_LEVEL featureLevel)

src/libANGLE/validationES2.cpp

@@ -1599,6 +1599,8 @@ static bool ValidateObjectIdentifierAndName(Context *context, GLenum identifier,
             context->handleError(Error(GL_INVALID_ENUM, "Invalid identifier."));
             return false;
     }
+
+    return true;
 }
 
 bool ValidateObjectLabelKHR(Context *context,