Make sure commit position is a string.

In Python 3, you have to be careful to distinguish between bytes and strings when reading from subprocesses; the code to read the commit position was failing to do that in one place. Bug: chromium:1112471 Change-Id: Ifbfba6872f762d7e5d7e356772e93b4a7ee1dfeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508746 Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Make sure commit position is a string.
5c79613f · Dirk Pranke · Commit Bot · fcd35965 · 5c79613f
Commit 5c79613f authored Oct 29, 2020 by Dirk Pranke Committed by Commit Bot Oct 30, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

commit_id.py src/commit_id.py +2 -1

No files found.
--- a/src/commit_id.py
+++ b/src/commit_id.py
@@ -17,7 +17,8 @@ Usage: commit_id.py check                - check if git is present


 def grab_output(command, cwd):
-    return sp.Popen(command, stdout=sp.PIPE, shell=True, cwd=cwd).communicate()[0].strip()
+    return sp.Popen(
+        command, stdout=sp.PIPE, shell=True, cwd=cwd).communicate()[0].strip().decode('utf-8')


 def get_commit_position(cwd):