X11Window: fix the behavior of setVisible

An obvious bug crept in setVisible where setVisible(true) twice would end up hiding the window. BUG=angleproject:1145 Change-Id: Iea8ca3de4ab8c05e6da66fb04c8d377824547b41 Reviewed-on: https://chromium-review.googlesource.com/324090 Tryjob-Request: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Tested-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

X11Window: fix the behavior of setVisible
5c896691 · Corentin Wallez · b3844843 · 5c896691
Commit 5c896691 authored Jan 26, 2016 by Corentin Wallez
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

X11Window.cpp util/x11/X11Window.cpp +6 -1

No files found.
--- a/util/x11/X11Window.cpp
+++ b/util/x11/X11Window.cpp
@@ -349,7 +349,12 @@ bool X11Window::resize(int width, int height)

 void X11Window::setVisible(bool isVisible)
 {
-    if (mVisible != isVisible)
+    if (mVisible == isVisible)
+    {
+        return;
+    }
+
+    if (isVisible)
    {
        XMapWindow(mDisplay, mWindow);