Align static and streaming vertex data to 16-byte boundaries.

Certain vertex formats using fewer than 4 bytes could confuse our buffer code, giving us improperly aligned offsets. Aligning vertex data across the board should fix the problem, and minimal cost. Change-Id: I6884b4ddcfb91ef309a970593aaf7932cb65712e Reviewed-on: https://chromium-review.googlesource.com/185196Reviewed-by: Shannon Woods <shannonwoods@chromium.org> Tested-by: Jamie Madill <jmadill@chromium.org>

Align static and streaming vertex data to 16-byte boundaries.
5f6937ca · Jamie Madill · 4a667fe9 · 5f6937ca
Commit 5f6937ca authored Feb 12, 2014 by Jamie Madill
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

VertexBuffer.cpp src/libGLESv2/renderer/VertexBuffer.cpp +8 -0

No files found.
--- a/src/libGLESv2/renderer/VertexBuffer.cpp
+++ b/src/libGLESv2/renderer/VertexBuffer.cpp
@@ -12,6 +12,7 @@
 #include "libGLESv2/renderer/Renderer.h"
 #include "libGLESv2/VertexAttribute.h"
 #include "libGLESv2/renderer/BufferStorage.h"
+#include "common/mathutil.h"

 namespace rx
 {
@@ -120,6 +121,9 @@ bool VertexBufferInterface::storeVertexAttributes(const gl::VertexAttribute &att

    mWritePosition += spaceRequired;

+    // Align to 16-byte boundary
+    mWritePosition = rx::roundUp(mWritePosition, 16u);
+
    return true;
 }

@@ -138,6 +142,10 @@ bool VertexBufferInterface::reserveVertexSpace(const gl::VertexAttribute &attrib
    }

    mReservedSpace += requiredSpace;
+
+    // Align to 16-byte boundary
+    mReservedSpace = rx::roundUp(mReservedSpace, 16u);
+
    return true;
 }