Commit 5fd17eb7 by Luc Ferron

Revert "Fix dEQP renderbuffer unspecified attachment test."

This seems to have caused a regression in Chrome. I'm reverting the change and suppressing the test that is failing on our end because of it. Once we can confirm this solves the problem, we'll need some help investigating further. This reverts commit c0db9add. Bug: angleproject:2321 Bug: chromium:833809 Change-Id: I5e40364217e15ae6117f5288a4754b25d983ca0a Reviewed-on: https://chromium-review.googlesource.com/1017763 Commit-Queue: Luc Ferron <lucferron@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> (cherry picked from commit 1d97a4d0) Reviewed-on: https://chromium-review.googlesource.com/1028490Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
parent d915203f
...@@ -182,32 +182,32 @@ void FramebufferAttachment::attach(const Context *context, ...@@ -182,32 +182,32 @@ void FramebufferAttachment::attach(const Context *context,
GLuint FramebufferAttachment::getRedSize() const GLuint FramebufferAttachment::getRedSize() const
{ {
return getSize().empty() ? 0 : getFormat().info->redBits; return getFormat().info->redBits;
} }
GLuint FramebufferAttachment::getGreenSize() const GLuint FramebufferAttachment::getGreenSize() const
{ {
return getSize().empty() ? 0 : getFormat().info->greenBits; return getFormat().info->greenBits;
} }
GLuint FramebufferAttachment::getBlueSize() const GLuint FramebufferAttachment::getBlueSize() const
{ {
return getSize().empty() ? 0 : getFormat().info->blueBits; return getFormat().info->blueBits;
} }
GLuint FramebufferAttachment::getAlphaSize() const GLuint FramebufferAttachment::getAlphaSize() const
{ {
return getSize().empty() ? 0 : getFormat().info->alphaBits; return getFormat().info->alphaBits;
} }
GLuint FramebufferAttachment::getDepthSize() const GLuint FramebufferAttachment::getDepthSize() const
{ {
return getSize().empty() ? 0 : getFormat().info->depthBits; return getFormat().info->depthBits;
} }
GLuint FramebufferAttachment::getStencilSize() const GLuint FramebufferAttachment::getStencilSize() const
{ {
return getSize().empty() ? 0 : getFormat().info->stencilBits; return getFormat().info->stencilBits;
} }
GLenum FramebufferAttachment::getComponentType() const GLenum FramebufferAttachment::getComponentType() const
......
...@@ -28,6 +28,10 @@ ...@@ -28,6 +28,10 @@
998 DEBUG RELEASE : dEQP-GLES3.stress.* = SKIP 998 DEBUG RELEASE : dEQP-GLES3.stress.* = SKIP
1101 DEBUG RELEASE : dEQP-GLES3.functional.flush_finish.* = SKIP 1101 DEBUG RELEASE : dEQP-GLES3.functional.flush_finish.* = SKIP
// Figure out why this caused this regression in Chrome:
// https://bugs.chromium.org/p/chromium/issues/detail?id=833809#
2321 DEBUG RELEASE : dEQP-GLES3.functional.state_query.fbo.framebuffer_unspecified_attachment_x_size_rbo = FAIL
// TODO(jmadill): Figure out why these fail on the bots, but not locally. // TODO(jmadill): Figure out why these fail on the bots, but not locally.
1108 WIN : dEQP-GLES3.functional.shaders.struct.local.dynamic_loop_struct_array_fragment = FAIL 1108 WIN : dEQP-GLES3.functional.shaders.struct.local.dynamic_loop_struct_array_fragment = FAIL
1094 WIN : dEQP-GLES3.functional.shaders.invariance.highp.loop_2 = FAIL 1094 WIN : dEQP-GLES3.functional.shaders.invariance.highp.loop_2 = FAIL
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment