Reland "Temporarily disable creating D3D debug device."

This reverts commit 28394c22. Reason for revert: may be the cause of flakiness on Win10 Debug (NVIDIA) per http://crbug.com/972914 . Original change's description: > Revert "Temporarily disable creating D3D debug device." > > This reverts commit 3d544fff. > > Reason for revert: Seems like flakiness is not related. > > Suppress D3D11 test failures uncovered by re-enabling D3D debug device: > ComputeShaderTest.DispatchCompute > Texture2DTestES3.TextureImplPropogatesDirtyBits > D3DTextureTestMS.* > > Also a small fix to ANGLETestBase::checkD3D11SDKLayersMessages > to clear reported messages, otherwise the failures are also reported > for tests following the one with the actual failure. > > Original change's description: > > Temporarily disable creating D3D debug device. > > > > To diagnose whether Windows Intel end2end tests flakiness > > is related to creating debug device and new version of Windows SDK. > > > > Bug: angleproject:3153 > > Change-Id: Ica7eae3fe875e22203b6dfd98b83604d66a97737 > > Reviewed-on: https://chromium-review.googlesource.com/c/1476954 > > Reviewed-by: Geoff Lang <geofflang@chromium.org> > > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > > Bug: angleproject:3153, angleproject:3493 > Bug: angleproject:3501, angleproject:3512, angleproject:3513 > > Change-Id: I232da72aa09c2b9230cf179dd54e1731f8365f8e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1480854 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> TBR=ynovikov@chromium.org,geofflang@chromium.org,jmadill@chromium.org Change-Id: I38a5cc9bb6ebcd50e97e40cc972a82679e73732a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3153, angleproject:3493, angleproject:3501, angleproject:3512, angleproject:3513 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1652784Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>

Reland "Temporarily disable creating D3D debug device."
6064e6ab · Kenneth Russell · Commit Bot · 1b5ad312 · 6064e6ab · 6064e6ab
Commit 6064e6ab authored Jun 11, 2019 by Kenneth Russell Committed by Commit Bot Jun 11, 2019
5 changed files
--- a/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
+++ b/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
@@ -513,7 +513,7 @@ Renderer11::Renderer11(egl::Display *display)
                UNREACHABLE();
        }

-        mCreateDebugDevice = ShouldUseDebugLayers(attributes);
+        mCreateDebugDevice = false;
    }
    else if (mDisplay->getPlatform() == EGL_PLATFORM_DEVICE_EXT)
    {

--- a/src/tests/gl_tests/ComputeShaderTest.cpp
+++ b/src/tests/gl_tests/ComputeShaderTest.cpp
@@ -365,9 +365,6 @@ void main()
 // Use glDispatchCompute to define work group count.
 TEST_P(ComputeShaderTest, DispatchCompute)
 {
-    // D3D Debug device reports an error. http://anglebug.com/3512
-    ANGLE_SKIP_TEST_IF(IsWindows() && IsD3D11());
-
    constexpr char kCS[] = R"(#version 310 es
 layout(local_size_x=4, local_size_y=3, local_size_z=2) in;
 layout(rgba32ui) uniform highp writeonly uimage2D imageOut;

--- a/src/tests/gl_tests/D3DTextureTest.cpp
+++ b/src/tests/gl_tests/D3DTextureTest.cpp
@@ -1200,6 +1200,5 @@ TEST_P(D3DTextureTestMS, CopyTexSubImage2DTest)
 // tests should be run against.
 ANGLE_INSTANTIATE_TEST(D3DTextureTest, ES2_D3D9(), ES2_D3D11(), ES2_OPENGL(), ES2_VULKAN());
 ANGLE_INSTANTIATE_TEST(D3DTextureTestES3, ES3_D3D11(), ES3_OPENGL());
-// D3D Debug device reports an error. http://anglebug.com/3513
-// ANGLE_INSTANTIATE_TEST(D3DTextureTestMS, ES2_D3D11());
+ANGLE_INSTANTIATE_TEST(D3DTextureTestMS, ES2_D3D11());
 }  // namespace angle
--- a/src/tests/gl_tests/TextureTest.cpp
+++ b/src/tests/gl_tests/TextureTest.cpp
@@ -1936,8 +1936,6 @@ TEST_P(Texture2DTestES3, TextureImplPropogatesDirtyBits)
    ANGLE_SKIP_TEST_IF(IsIntel() && IsOpenGL());
    // Flaky hangs on Win10 AMD RX 550 GL. http://anglebug.com/3371
    ANGLE_SKIP_TEST_IF(IsWindows() && IsAMD() && IsOpenGL());
-    // D3D Debug device reports an error. http://anglebug.com/3501
-    ANGLE_SKIP_TEST_IF(IsWindows() && IsD3D11());

    // The workaround in the GL backend required to trigger this bug generates driver warning
    // messages.

--- a/src/tests/test_utils/ANGLETest.cpp
+++ b/src/tests/test_utils/ANGLETest.cpp
@@ -1057,7 +1057,6 @@ void ANGLETestBase::checkD3D11SDKLayersMessages()
                    free(pMessage);
                }
            }
-            infoQueue->ClearStoredMessages();

            FAIL() << numStoredD3DDebugMessages
                   << " D3D11 SDK Layers message(s) detected! Test Failed.\n";