Remove angle::Library and its usages

src/tests/test_utils/ANGLETest.cpp

@@ -929,8 +929,6 @@ bool ANGLETestBase::InitTestWindow()
 
     mOSWindow->setVisible(true);
 
-    mGLESLibrary.reset(angle::loadLibrary("libGLESv2"));
-
     return true;
 }
 
@@ -944,8 +942,6 @@ bool ANGLETestBase::DestroyTestWindow()
         mOSWindow = nullptr;
     }
 
-    mGLESLibrary.reset(nullptr);
-
     return true;
 }
 
@@ -1129,7 +1125,6 @@ ANGLETestBase::ScopedIgnorePlatformMessages::~ScopedIgnorePlatformMessages()
 
 OSWindow *ANGLETestBase::mOSWindow = nullptr;
 Optional<EGLint> ANGLETestBase::mLastRendererType;
-std::unique_ptr<angle::Library> ANGLETestBase::mGLESLibrary;
 
 void ANGLETestEnvironment::SetUp()
 {

src/tests/test_utils/ANGLETest.h

@@ -391,9 +391,6 @@ class ANGLETestBase
 
     // Workaround for NVIDIA not being able to share a window with OpenGL and Vulkan.
     static Optional<EGLint> mLastRendererType;
-
-    // For loading and freeing platform
-    static std::unique_ptr<angle::Library> mGLESLibrary;
 };
 
 class ANGLETest : public ANGLETestBase, public ::testing::TestWithParam<angle::PlatformParameters>

util/posix/Posix_system_utils.cpp

@@ -47,45 +47,4 @@ void WriteDebugMessage(const char *format, ...)
     // TODO(jmadill): Implement this
 }
 
-class PosixLibrary : public Library
-{
-  public:
-    PosixLibrary(const std::string &libraryName);
-    ~PosixLibrary() override;
-
-    void *getSymbol(const std::string &symbolName) override;
-
-  private:
-    void *mModule;
-};
-
-PosixLibrary::PosixLibrary(const std::string &libraryName) : mModule(nullptr)
-{
-    const auto &fullName = libraryName + "." + GetSharedLibraryExtension();
-    mModule              = dlopen(fullName.c_str(), RTLD_NOW);
-}
-
-PosixLibrary::~PosixLibrary()
-{
-    if (mModule)
-    {
-        dlclose(mModule);
-    }
-}
-
-void *PosixLibrary::getSymbol(const std::string &symbolName)
-{
-    if (!mModule)
-    {
-        return nullptr;
-    }
-
-    return dlsym(mModule, symbolName.c_str());
-}
-
-Library *loadLibrary(const std::string &libraryName)
-{
-    return new PosixLibrary(libraryName);
-}
-
 } // namespace angle

util/system_utils.h

@@ -27,15 +27,6 @@ ANGLE_EXPORT void SetLowPriorityProcess();
 // Write a debug message, either to a standard output or Debug window.
 ANGLE_EXPORT void WriteDebugMessage(const char *format, ...);
 
-class ANGLE_EXPORT Library : angle::NonCopyable
-{
-  public:
-    virtual ~Library() {}
-    virtual void *getSymbol(const std::string &symbolName) = 0;
-};
-
-ANGLE_EXPORT Library *loadLibrary(const std::string &libraryName);
-
 } // namespace angle
 
 #endif  // UTIL_SYSTEM_UTILS_H_

util/windows/win32/Win32_system_utils.cpp

@@ -19,45 +19,4 @@ void SetLowPriorityProcess()
     SetPriorityClass(GetCurrentProcess(), BELOW_NORMAL_PRIORITY_CLASS);
 }
 
-class Win32Library : public Library
-{
-  public:
-    Win32Library(const std::string &libraryName);
-    ~Win32Library() override;
-
-    void *getSymbol(const std::string &symbolName) override;
-
-  private:
-    HMODULE mModule;
-};
-
-Win32Library::Win32Library(const std::string &libraryName) : mModule(nullptr)
-{
-    const auto &fullName = libraryName + "." + GetSharedLibraryExtension();
-    mModule              = LoadLibraryA(fullName.c_str());
-}
-
-Win32Library::~Win32Library()
-{
-    if (mModule)
-    {
-        FreeLibrary(mModule);
-    }
-}
-
-void *Win32Library::getSymbol(const std::string &symbolName)
-{
-    if (!mModule)
-    {
-        return nullptr;
-    }
-
-    return GetProcAddress(mModule, symbolName.c_str());
-}
-
-Library *loadLibrary(const std::string &libraryName)
-{
-    return new Win32Library(libraryName);
-}
-
 }  // namespace angle

util/windows/winrt/WinRT_system_utils.cpp

@@ -19,10 +19,4 @@ void SetLowPriorityProcess()
     // No equivalent to this in WinRT
 }
 
-Library *loadLibrary(const std::string &libraryName)
-{
-    // WinRT cannot load code dynamically.
-    return nullptr;
-}
-
 }  // namespace angle