Commit 624ce6a3 by Jamie Madill Committed by Commit Bot

Pass GN header visibility check.

Updates angle_util to see the loader includes even if the loader is not enabled. This makes the GN check happy. Bug: angleproject:3052 Change-Id: Ifd23070385beefede4358c7b4c1823dc87b5ded8 Reviewed-on: https://chromium-review.googlesource.com/c/1395809Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 9db8df4c
...@@ -22,7 +22,7 @@ secondary_source = "//build/secondary/" ...@@ -22,7 +22,7 @@ secondary_source = "//build/secondary/"
# matching these patterns (see "gn help label_pattern" for format) will have # matching these patterns (see "gn help label_pattern" for format) will have
# their includes checked for proper dependencies when you run either # their includes checked for proper dependencies when you run either
# "gn check" or "gn gen --check". # "gn check" or "gn gen --check".
check_targets = [] check_targets = ["*"]
# These are the list of GN files that run exec_script. This whitelist exists # These are the list of GN files that run exec_script. This whitelist exists
# to force additional review for new uses of exec_script, which is strongly # to force additional review for new uses of exec_script, which is strongly
......
...@@ -887,13 +887,9 @@ source_set("angle_util_loader_headers") { ...@@ -887,13 +887,9 @@ source_set("angle_util_loader_headers") {
"util/util_export.h", "util/util_export.h",
] ]
public_configs = [ if (is_win) {
":angle_util_config", sources += [ "util/windows/wgl_loader_autogen.h" ]
":angle_util_loader_config", }
":extra_warnings",
":internal_config",
":no_gl_prototypes",
]
public_deps = [ public_deps = [
":includes", ":includes",
...@@ -909,12 +905,21 @@ source_set("angle_util_loader") { ...@@ -909,12 +905,21 @@ source_set("angle_util_loader") {
] ]
if (is_win) { if (is_win) {
sources += util_wgl_sources sources += [ "util/windows/wgl_loader_autogen.cpp" ]
} }
public_deps = [ deps = [
":angle_util_loader_headers", ":angle_util_loader_headers",
] ]
public_configs = [
":angle_util_config",
":angle_util_loader_config",
":internal_config",
":no_gl_prototypes",
]
configs += [ ":extra_warnings" ]
} }
config("angle_util_config") { config("angle_util_config") {
...@@ -943,7 +948,7 @@ foreach(is_shared_library, ...@@ -943,7 +948,7 @@ foreach(is_shared_library,
sources = util_sources sources = util_sources
if (is_win) { if (is_win) {
sources += util_win32_sources sources += util_win_sources
} }
libs = [] libs = []
...@@ -998,6 +1003,7 @@ foreach(is_shared_library, ...@@ -998,6 +1003,7 @@ foreach(is_shared_library,
deps = [ deps = [
":angle_common", ":angle_common",
":angle_util_loader_headers",
] ]
if (is_shared_library) { if (is_shared_library) {
...@@ -1011,8 +1017,13 @@ foreach(is_shared_library, ...@@ -1011,8 +1017,13 @@ foreach(is_shared_library,
public_configs += [ ":shared_library_public_config" ] public_configs += [ ":shared_library_public_config" ]
} }
deps += [ ":angle_util_loader" ] if (is_win) {
public_configs += [ ":no_gl_prototypes" ] sources += util_win_shared_sources
}
public_deps = [
":angle_util_loader",
]
} else { } else {
public_configs += [ public_configs += [
":angle_static", ":angle_static",
......
...@@ -26,7 +26,7 @@ util_sources = [ ...@@ -26,7 +26,7 @@ util_sources = [
"util/Timer.h", "util/Timer.h",
] ]
util_win32_sources = [ util_win_sources = [
"util/windows/win32/Win32_system_utils.cpp", "util/windows/win32/Win32_system_utils.cpp",
"util/windows/win32/Win32Pixmap.cpp", "util/windows/win32/Win32Pixmap.cpp",
"util/windows/win32/Win32Pixmap.h", "util/windows/win32/Win32Pixmap.h",
...@@ -37,11 +37,9 @@ util_win32_sources = [ ...@@ -37,11 +37,9 @@ util_win32_sources = [
"util/windows/WindowsTimer.h", "util/windows/WindowsTimer.h",
] ]
util_wgl_sources = [ util_win_shared_sources = [
"util/windows/WGLWindow.cpp", "util/windows/WGLWindow.cpp",
"util/windows/WGLWindow.h", "util/windows/WGLWindow.h",
"util/windows/wgl_loader_autogen.cpp",
"util/windows/wgl_loader_autogen.h",
] ]
util_winrt_sources = [ util_winrt_sources = [
......
...@@ -11,6 +11,9 @@ ...@@ -11,6 +11,9 @@
#if defined(ANGLE_USE_UTIL_LOADER) #if defined(ANGLE_USE_UTIL_LOADER)
# include "util/egl_loader_autogen.h" # include "util/egl_loader_autogen.h"
# include "util/gles_loader_autogen.h" # include "util/gles_loader_autogen.h"
# if defined(ANGLE_PLATFORM_WINDOWS)
# include "util/windows/wgl_loader_autogen.h"
# endif // defined(ANGLE_PLATFORM_WINDOWS)
#else #else
# if !defined(GL_GLES_PROTOTYPES) # if !defined(GL_GLES_PROTOTYPES)
...@@ -20,6 +23,6 @@ ...@@ -20,6 +23,6 @@
# include <EGL/egl.h> # include <EGL/egl.h>
# include <EGL/eglext.h> # include <EGL/eglext.h>
# include "angle_gl.h" # include "angle_gl.h"
#endif #endif // defined(ANGLE_USE_UTIL_LOADER)
#endif // UTIL_GL_H_ #endif // UTIL_GL_H_
...@@ -11,9 +11,7 @@ ...@@ -11,9 +11,7 @@
#include "common/string_utils.h" #include "common/string_utils.h"
#include "util/OSWindow.h" #include "util/OSWindow.h"
#include "util/gles_loader_autogen.h"
#include "util/system_utils.h" #include "util/system_utils.h"
#include "util/windows/wgl_loader_autogen.h"
#include <iostream> #include <iostream>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment