Add missing check in Compiler

Further AST traversals should not be run in case the expression complexity check failed and set success=false. Otherwise traversal can result in stack overflow. BUG=chromium:780545 TEST=WebGL conformance tests Change-Id: Icfde8c051038c691563e199a6d3a17b1e8e5ebf5 Reviewed-on: https://chromium-review.googlesource.com/750781 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Add missing check in Compiler
640d597d · Olli Etuaho · Commit Bot · 4ef25033 · 640d597d
Commit 640d597d authored Nov 02, 2017 by Olli Etuaho Committed by Commit Bot Nov 02, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

Compiler.cpp src/compiler/translator/Compiler.cpp +2 -1

No files found.
--- a/src/compiler/translator/Compiler.cpp
+++ b/src/compiler/translator/Compiler.cpp
@@ -395,7 +395,8 @@ TIntermBlock *TCompiler::compileTreeImpl(const char *const shaderStrings[],
            RemoveNoOpCasesFromEndOfSwitchStatements(root, &symbolTable);

        // Remove empty switch statements - this makes output simpler.
-        RemoveEmptySwitchStatements(root);
+        if (success)
+            RemoveEmptySwitchStatements(root);

        // Create the function DAG and check there is no recursion
        if (success)