Clean up RecordConstantPrecision interaction with switch/case

There were two bugs here that were masking each other: 1. Case nodes were not being added to AST traversal path. 2. RecordConstantPrecision did not check if a constant was a child of a case node. Fix these. BUG=angleproject:1490 TEST=WebGL 2 conformance tests Change-Id: Ic6cb7942bf57870fa26eb6a011919a2d7951cc85 Reviewed-on: https://chromium-review.googlesource.com/394588Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Clean up RecordConstantPrecision interaction with switch/case
65c79dbc · Olli Etuaho · Commit Bot · 5d9f5df0 · 65c79dbc · 65c79dbc
Commit 65c79dbc authored Oct 06, 2016 by Olli Etuaho Committed by Commit Bot Oct 06, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 0 deletions

IntermTraverse.cpp src/compiler/translator/IntermTraverse.cpp +4 -0

RecordConstantPrecision.cpp src/compiler/translator/RecordConstantPrecision.cpp +5 -0

No files found.
--- a/src/compiler/translator/IntermTraverse.cpp
+++ b/src/compiler/translator/IntermTraverse.cpp
@@ -680,7 +680,11 @@ void TIntermTraverser::traverseCase(TIntermCase *node)
        visit = visitCase(PreVisit, node);
    if (visit && node->getCondition())
+    {
+        incrementDepth(node);
        node->getCondition()->traverse(this);
+        decrementDepth();
+    }
    if (visit && postVisit)
        visitCase(PostVisit, node);

--- a/src/compiler/translator/RecordConstantPrecision.cpp
+++ b/src/compiler/translator/RecordConstantPrecision.cpp
@@ -45,6 +45,11 @@ RecordConstantPrecisionTraverser::RecordConstantPrecisionTraverser()
 bool RecordConstantPrecisionTraverser::operandAffectsParentOperationPrecision(TIntermTyped *operand)
 {
+    if (getParentNode()->getAsCaseNode())
+    {
+        return false;
+    }
    const TIntermBinary *parentAsBinary = getParentNode()->getAsBinaryNode();
    if (parentAsBinary != nullptr)
    {