Commit 68c8ed7a by Shahbaz Youssefi Committed by Commit Bot

Vulkan: More perf warnings

Perf warnings added in the CPU path for unpack buffers, as well as CPU readback of images. Bug: angleproject:3461 Bug: angleproject:4900 Change-Id: I0f716a1ea6110ba8e779903a7d5913d5f6df0ce9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376905Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent 710e408e
...@@ -414,6 +414,10 @@ angle::Result TextureVk::setSubImageImpl(const gl::Context *context, ...@@ -414,6 +414,10 @@ angle::Result TextureVk::setSubImageImpl(const gl::Context *context,
} }
else else
{ {
ANGLE_PERF_WARNING(contextVk->getDebug(), GL_DEBUG_SEVERITY_HIGH,
"TexSubImage with unpack buffer copied on CPU due to store, format "
"or offset restrictions");
void *mapPtr = nullptr; void *mapPtr = nullptr;
ANGLE_TRY(unpackBufferVk->mapImpl(contextVk, &mapPtr)); ANGLE_TRY(unpackBufferVk->mapImpl(contextVk, &mapPtr));
......
...@@ -5051,6 +5051,9 @@ angle::Result ImageHelper::readPixels(ContextVk *contextVk, ...@@ -5051,6 +5051,9 @@ angle::Result ImageHelper::readPixels(ContextVk *contextVk,
commandBuffer.copyImageToBuffer(src->getImage(), src->getCurrentLayout(), bufferHandle, 1, commandBuffer.copyImageToBuffer(src->getImage(), src->getCurrentLayout(), bufferHandle, 1,
&region); &region);
ANGLE_PERF_WARNING(contextVk->getDebug(), GL_DEBUG_SEVERITY_HIGH,
"GPU stall due to ReadPixels");
// Triggers a full finish. // Triggers a full finish.
// TODO(jmadill): Don't block on asynchronous readback. // TODO(jmadill): Don't block on asynchronous readback.
ANGLE_TRY(contextVk->finishImpl()); ANGLE_TRY(contextVk->finishImpl());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment