eglGetConfigAttrib validation missing extension check

The extension EGL_ANGLE_iosurface_client_buffer adds a new attribute to the config: EGL_BIND_TO_TEXTURE_TARGET_ANGLE. However, validation was not checking the extension was present when this attribute was requested. Bug: chromium:1015454 Change-Id: I24c6e20f3b602e8a71a46f0f1e99c1472d5bbb1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2078892 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

eglGetConfigAttrib validation missing extension check
698ffd02 · Jonah Ryan-Davis · Commit Bot · 4d2040a6 · 698ffd02
Commit 698ffd02 authored Feb 27, 2020 by Jonah Ryan-Davis Committed by Commit Bot Feb 27, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

validationEGL.cpp src/libANGLE/validationEGL.cpp +7 -1

No files found.
--- a/src/libANGLE/validationEGL.cpp
+++ b/src/libANGLE/validationEGL.cpp
@@ -178,7 +178,6 @@ Error ValidateConfigAttribute(const Display *display, EGLAttrib attribute)
        case EGL_SAMPLES:
        case EGL_SAMPLE_BUFFERS:
        case EGL_SURFACE_TYPE:
-        case EGL_BIND_TO_TEXTURE_TARGET_ANGLE:
        case EGL_TRANSPARENT_TYPE:
        case EGL_TRANSPARENT_BLUE_VALUE:
        case EGL_TRANSPARENT_GREEN_VALUE:
@@ -226,6 +225,13 @@ Error ValidateConfigAttribute(const Display *display, EGLAttrib attribute)
            }
            break;
+        case EGL_BIND_TO_TEXTURE_TARGET_ANGLE:
+            if (!display->getExtensions().iosurfaceClientBuffer)
+            {
+                return EglBadAttribute() << "EGL_ANGLE_iosurface_client_buffer is not enabled.";
+            }
+            break;
        default:
            return EglBadAttribute() << "Unknown attribute.";
    }