glTexStorage3D: Disallow compressed formats on GL_TEXTURE_3D targets.

GLES 3.0.4 p147: "If internalformat is an ETC2/EAC format, CompressedTexImage3D will generate an INVALID_OPERATION error if target is not TEXTURE_2D_ARRAY." This matches the validation of glTexImage3D. TEST=conformance2/textures/misc/tex-storage-compressed-formats.html BUG=chromium:983142 Change-Id: Ifc4ea9503182c43de7e58c4b45b59bb03ae2f901 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1698648Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>

glTexStorage3D: Disallow compressed formats on GL_TEXTURE_3D targets.
6c90ebb0 · Geoff Lang · Commit Bot · 943fe34e · 6c90ebb0
Commit 6c90ebb0 authored Jul 11, 2019 by Geoff Lang Committed by Commit Bot Jul 12, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

validationES3.cpp src/libANGLE/validationES3.cpp +6 -0

No files found.
--- a/src/libANGLE/validationES3.cpp
+++ b/src/libANGLE/validationES3.cpp
@@ -1157,6 +1157,12 @@ bool ValidateES3TexStorageParametersBase(Context *context,
        return false;
    }

+    if (formatInfo.compressed && target == TextureType::_3D)
+    {
+        context->validationError(GL_INVALID_OPERATION, kInvalidTextureTarget);
+        return false;
+    }
+
    return true;
 }