TracePerfTests: Don't call framebuffer functions on GLES1.

Skip unbinding the framebuffer on GLES1, where the function does not exist. This caused a crash when recording screenshots on native GLES1 implementations on Android. Bug: angleproject:5961 Change-Id: I7a35474154a4a8d56b36df02629944de7660dcd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891567 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>

TracePerfTests: Don't call framebuffer functions on GLES1.
6f35e366 · Lubosz Sarnecki · Commit Bot · 83689e32 · 6f35e366
Commit 6f35e366 authored May 12, 2021 by Lubosz Sarnecki Committed by Commit Bot May 14, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

TracePerfTest.cpp src/tests/perf_tests/TracePerfTest.cpp +7 -1

No files found.
--- a/src/tests/perf_tests/TracePerfTest.cpp
+++ b/src/tests/perf_tests/TracePerfTest.cpp
@@ -1530,7 +1530,13 @@ void TracePerfTest::saveScreenshot(const std::string &screenshotName)
    uint32_t pixelCount = mTestParams.windowWidth * mTestParams.windowHeight;
    std::vector<uint8_t> pixelData(pixelCount * 4);
-    glBindFramebuffer(GL_FRAMEBUFFER, 0);
+    // Only unbind the framebuffer on context versions where it's available.
+    const TraceInfo &traceInfo = GetTraceInfo(GetParam().testID);
+    if (traceInfo.contextClientMajorVersion > 1)
+    {
+        glBindFramebuffer(GL_FRAMEBUFFER, 0);
+    }
    glReadPixels(0, 0, mTestParams.windowWidth, mTestParams.windowHeight, GL_RGBA, GL_UNSIGNED_BYTE,
                 pixelData.data());