Print a warning on unexpected internal errors.

The error message can be dropped when converting angle::Result to egl::Error. This makes sure something is always printed when we get an unexpected error. BUG=914911 Change-Id: Icc8b06b1c13e3ea83287da5a217f4c8bc218deec Reviewed-on: https://chromium-review.googlesource.com/c/1378689Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Print a warning on unexpected internal errors.
7139b434 · Geoff Lang · Commit Bot · f3075842 · 7139b434
Commit 7139b434 authored Dec 14, 2018 by Geoff Lang Committed by Commit Bot Dec 15, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

Context.cpp src/libANGLE/Context.cpp +6 -1

No files found.
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -8155,8 +8155,13 @@ void ErrorSet::handleError(GLenum errorCode,
    errorStream << "Error: " << gl::FmtHex(errorCode) << ", in " << file << ", " << function << ":"
                << line << ". " << message;

+    std::string formattedMessage = errorStream.str();
+
+    // Always log a warning, this function is only called on unexpected internal errors.
+    WARN() << formattedMessage;
+
    // validationError does the necessary work to process the error.
-    validationError(errorCode, errorStream.str().c_str());
+    validationError(errorCode, formattedMessage.c_str());
 }

 void ErrorSet::validationError(GLenum errorCode, const char *message)