Revert "Vulkan: Add missing command pool reset."

This reverts commit 9aa865a6. Reason for revert: Seems to be causing crashes on Android in glmark2. Might also be responsible for a perf regression. Bug: angleproject:3542 Original change's description: > Vulkan: Add missing command pool reset. > > We were still calling destroy in checkCompletedCommands. We can > instead call reset. > > May not significantly impact performance. > > Bug: angleproject:3489 > Change-Id: I61a2cb154faac56dc78a49678dd822d81ce16ad2 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1647029 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Tobin Ehlis <tobine@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=tobine@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:3489 Change-Id: Icb0e99f18ecab09798654605973958bd2b263002 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665748Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Revert "Vulkan: Add missing command pool reset."
71ad2a73 · Jamie Madill · Commit Bot · 11b9dc59 · 71ad2a73
Commit 71ad2a73 authored Jun 18, 2019 by Jamie Madill Committed by Commit Bot Jun 18, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

ContextVk.cpp src/libANGLE/renderer/vulkan/ContextVk.cpp +1 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -2166,8 +2166,7 @@ angle::Result ContextVk::checkCompletedCommands()

        batch.fence.reset(device);
        TRACE_EVENT0("gpu.angle", "commandPool.destroy");
-        batch.commandPool.reset(device, 0);
-        mCommandPoolFreeList.emplace_back(std::move(batch.commandPool));
+        batch.commandPool.destroy(device);
        ++finishedCount;
    }