Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
angle
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
angle
Commits
73438870
Commit
73438870
authored
Sep 09, 2013
by
Zhenyao Mo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove literal overflow error reporting in compiler.
BUG= R=alokp@chromium.org Review URL:
https://codereview.appspot.com/13505047
parent
fc75e217
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
17 deletions
+1
-17
version.h
src/common/version.h
+1
-1
glslang.y
src/compiler/glslang.y
+0
-8
glslang_tab.cpp
src/compiler/glslang_tab.cpp
+0
-8
No files found.
src/common/version.h
View file @
73438870
#define MAJOR_VERSION 1
#define MINOR_VERSION 2
#define BUILD_VERSION 0
#define BUILD_REVISION 244
4
#define BUILD_REVISION 244
5
#define STRINGIFY(x) #x
#define MACRO_STRINGIFY(x) STRINGIFY(x)
...
...
src/compiler/glslang.y
View file @
73438870
...
...
@@ -228,14 +228,6 @@ primary_expression
$$ = $1;
}
| INTCONSTANT {
//
// INT_TYPE is only 16-bit plus sign bit for vertex/fragment shaders,
// check for overflow for constants
//
if (abs($1.i) >= (1 << 16)) {
context->error(@1, " integer constant overflow", "");
context->recover();
}
ConstantUnion *unionArray = new ConstantUnion[1];
unionArray->setIConst($1.i);
$$ = context->intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), @1);
...
...
src/compiler/glslang_tab.cpp
View file @
73438870
...
...
@@ -2298,14 +2298,6 @@ yyreduce:
case
6
:
{
//
// INT_TYPE is only 16-bit plus sign bit for vertex/fragment shaders,
// check for overflow for constants
//
if
(
abs
((
yyvsp
[(
1
)
-
(
1
)].
lex
).
i
)
>=
(
1
<<
16
))
{
context
->
error
((
yylsp
[(
1
)
-
(
1
)]),
" integer constant overflow"
,
""
);
context
->
recover
();
}
ConstantUnion
*
unionArray
=
new
ConstantUnion
[
1
];
unionArray
->
setIConst
((
yyvsp
[(
1
)
-
(
1
)].
lex
).
i
);
(
yyval
.
interm
.
intermTypedNode
)
=
context
->
intermediate
.
addConstantUnion
(
unionArray
,
TType
(
EbtInt
,
EbpUndefined
,
EvqConst
),
(
yylsp
[(
1
)
-
(
1
)]));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment