Clang warn implicit float to int conversion

BUILD.gn

@@ -122,6 +122,7 @@ config("extra_warnings") {
       # Enable after anglebug.com/3128 is fixed.
       # "-Wextra-semi-stmt",
 
+      "-Wfloat-conversion",
       "-Wnon-virtual-dtor",
       "-Wunneeded-internal-declaration",
     ]

src/common/matrix_utils.h

@@ -335,7 +335,7 @@ class Matrix
         Matrix<T> result(std::vector<T>(mElements.size()), rows(), columns());
         for (unsigned int i = 0; i < rows(); i++)
             for (unsigned int j = 0; j < columns(); j++)
-                result(i, j) = det ? adjugateMatrix(i, j) / det : T();
+                result(i, j) = (det != static_cast<T>(0)) ? adjugateMatrix(i, j) / det : T();
 
         return result;
     }

src/compiler/translator/IntermNode.cpp

@@ -2953,7 +2953,7 @@ TConstantUnion *TIntermConstantUnion::foldUnaryComponentWise(TOperator op,
                 ASSERT(getType().getBasicType() == EbtFloat);
                 float x      = operandArray[i].getFConst();
                 float length = VectorLength(operandArray, objectSize);
-                if (length)
+                if (length != 0.0f)
                     resultArray[i].setFConst(x / length);
                 else
                     UndefinedConstantFoldingError(getLine(), op, getType().getBasicType(),

src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm

@@ -298,12 +298,12 @@ void WindowSurfaceCGL::setSwapInterval(EGLint interval)
 
 EGLint WindowSurfaceCGL::getWidth() const
 {
-    return CGRectGetWidth([mLayer frame]);
+    return (EGLint)CGRectGetWidth([mLayer frame]);
 }
 
 EGLint WindowSurfaceCGL::getHeight() const
 {
-    return CGRectGetHeight([mLayer frame]);
+    return (EGLint)CGRectGetHeight([mLayer frame]);
 }
 
 EGLint WindowSurfaceCGL::isPostSubBufferSupported() const

util/osx/OSXWindow.mm

@@ -129,8 +129,8 @@ static float YCoordToFromCG(float y)
     NSSize windowSize = [[mWindow->getNSWindow() contentView] frame].size;
     Event event;
     event.Type        = Event::EVENT_RESIZED;
-    event.Size.Width  = windowSize.width;
-    event.Size.Height = windowSize.height;
+    event.Size.Width  = (int)windowSize.width;
+    event.Size.Height = (int)windowSize.height;
     mWindow->pushEvent(event);
 }
 
@@ -139,8 +139,8 @@ static float YCoordToFromCG(float y)
     NSRect screenspace = [mWindow->getNSWindow() frame];
     Event event;
     event.Type   = Event::EVENT_MOVED;
-    event.Move.X = screenspace.origin.x;
-    event.Move.Y = YCoordToFromCG(screenspace.origin.y + screenspace.size.height);
+    event.Move.X = (int)screenspace.origin.x;
+    event.Move.Y = (int)YCoordToFromCG(screenspace.origin.y + screenspace.size.height);
     mWindow->pushEvent(event);
 }
 
@@ -474,8 +474,8 @@ static MouseButton TranslateMouseButton(int button)
     Event event;
     event.Type               = eventType;
     event.MouseButton.Button = button;
-    event.MouseButton.X      = [nsEvent locationInWindow].x;
-    event.MouseButton.Y      = [self translateMouseY:[nsEvent locationInWindow].y];
+    event.MouseButton.X      = (int)[nsEvent locationInWindow].x;
+    event.MouseButton.Y      = (int)[self translateMouseY:[nsEvent locationInWindow].y];
     mWindow->pushEvent(event);
 }
 
@@ -498,8 +498,8 @@ static MouseButton TranslateMouseButton(int button)
 {
     Event event;
     event.Type        = Event::EVENT_MOUSE_MOVED;
-    event.MouseMove.X = [nsEvent locationInWindow].x;
-    event.MouseMove.Y = [self translateMouseY:[nsEvent locationInWindow].y];
+    event.MouseMove.X = (int)[nsEvent locationInWindow].x;
+    event.MouseMove.Y = (int)[self translateMouseY:[nsEvent locationInWindow].y];
     mWindow->pushEvent(event);
 }
 
@@ -560,7 +560,7 @@ static MouseButton TranslateMouseButton(int button)
 
     Event event;
     event.Type             = Event::EVENT_MOUSE_WHEEL_MOVED;
-    event.MouseWheel.Delta = [nsEvent deltaY];
+    event.MouseWheel.Delta = (int)[nsEvent deltaY];
     mWindow->pushEvent(event);
 }
 
@@ -718,7 +718,7 @@ void OSXWindow::messageLoop()
 
 void OSXWindow::setMousePosition(int x, int y)
 {
-    y = [mWindow frame].size.height - y - 1;
+    y = (int)([mWindow frame].size.height) - y - 1;
     NSPoint screenspace;
 
 #if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_7
@@ -733,7 +733,7 @@ bool OSXWindow::setPosition(int x, int y)
 {
     // Given CG and NS's coordinate system, the "Y" position of a window is the Y coordinate
     // of the bottom of the window.
-    int newBottom    = [mWindow frame].size.height + y;
+    int newBottom    = (int)([mWindow frame].size.height) + y;
     NSRect emptyRect = NSMakeRect(x, YCoordToFromCG(newBottom), 0, 0);
     [mWindow setFrameOrigin:[mWindow frameRectForContentRect:emptyRect].origin];
     return true;