Commit 76a93c33 by Sami Väisänen Committed by Commit Bot

Remove skipping of several tests on NVIDIA since they are now passing

Remove skipping of several tests on NVIDIA since they are now passing. - MissingReturnStructOfArrays - DrawWithLevelsOutsideRangeWithInconsistentDimensions - TextureFormatChangesWithBaseLevel - TextureLuminance16Implicit BUG=angleproject:3849 BUG=angleproject:1305 BUG=angleproject:596 Change-Id: Ie3c3ba6634a251a7320a61c6c4cc03cb178db925 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1763964Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 2697f1f0
......@@ -1280,12 +1280,6 @@ TEST_P(GLSLTest_ES3, MissingReturnArrayOfStructs)
// Verify that functions without return statements still compile
TEST_P(GLSLTest_ES3, MissingReturnStructOfArrays)
{
// TODO(cwallez) remove the suppression once NVIDIA drivers are updated across trybots, drivers
// since late 2016 should have the fix. Last check on 2017-05-30 revealed that the Windows
// Server 2008 bots still had the old, failing drivers.
// It disallows returning structure of arrays on NVIDIA OpenGL ES.
ANGLE_SKIP_TEST_IF(IsNVIDIA() && IsOpenGLES());
constexpr char kVS[] =
"#version 300 es\n"
"in float v_varying;\n"
......
......@@ -2298,10 +2298,6 @@ TEST_P(Texture2DArrayTestES3, DrawWithLevelsOutsideRangeWithInconsistentDimensio
ANGLE_SKIP_TEST_IF(IsIntel() && IsWindows() && IsOpenGL());
// NVIDIA was observed drawing color 0,0,0,0 instead of the texture color after the base
// level was changed.
ANGLE_SKIP_TEST_IF(IsNVIDIA() && (IsOpenGL() || IsOpenGLES()));
// Switch the level that is being used to the cyan level 2.
glTexParameteri(GL_TEXTURE_2D_ARRAY, GL_TEXTURE_BASE_LEVEL, 2);
glTexParameteri(GL_TEXTURE_2D_ARRAY, GL_TEXTURE_MAX_LEVEL, 2);
......@@ -2487,9 +2483,6 @@ TEST_P(Texture2DTestES3, ImmutableTextureBaseLevelOutOfRange)
// Test that changing base level works when it affects the format of the texture.
TEST_P(Texture2DTestES3, TextureFormatChangesWithBaseLevel)
{
// Observed rendering corruption on NVIDIA OpenGL.
ANGLE_SKIP_TEST_IF(IsNVIDIA() && IsOpenGL());
ANGLE_SKIP_TEST_IF(IsIntel() && IsWindows() && IsDesktopOpenGL());
// Observed incorrect rendering on AMD OpenGL.
......@@ -2833,7 +2826,6 @@ TEST_P(Texture2DTest, TextureLuminance16ImplicitAlpha1)
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float"));
ANGLE_SKIP_TEST_IF(IsD3D9());
ANGLE_SKIP_TEST_IF(IsVulkan());
ANGLE_SKIP_TEST_IF(IsNVIDIA() && IsOpenGLES());
// TODO(ynovikov): re-enable once root cause of http://anglebug.com/1420 is fixed
ANGLE_SKIP_TEST_IF(IsAndroid() && IsAdreno() && IsOpenGLES());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment