Revert "Enable blob cache when debugging"

This reverts commit 617cb015. Reason for revert: Seems to cause rolls in Chromium to fail: https://chromium-review.googlesource.com/c/chromium/src/+/2127135 Original change's description: > Enable blob cache when debugging > > We've had several issues with shader caches which are only implemented > on Android which makes them challenging to debug. > The existing BlobCache object has a default implementation that is > disabled by default. When debug layers are enabled resize the default > cache so that it gets used and provides behavior closer to Android. > This caching will be enabled when debug layers are enabled, e.g. > EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. > This is done for angle_end2end_tests and deqp tests. > > Bug: b:152292873 > Change-Id: I9dcd90a1a8da88127bf8dac25031056b7279207e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113133 > Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=courtneygo@google.com,ianelliott@google.com,jmadill@chromium.org Change-Id: I42a445b93eff1237b05a82d2836c218b9bbbd08b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:152292873 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128106Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Revert "Enable blob cache when debugging"
7939e367 · Corentin Wallez · Commit Bot · 74e816bf · 7939e367
Commit 7939e367 authored Mar 30, 2020 by Corentin Wallez Committed by Commit Bot Mar 30, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 8 deletions

Display.cpp src/libANGLE/Display.cpp +0 -8

No files found.
--- a/src/libANGLE/Display.cpp
+++ b/src/libANGLE/Display.cpp
@@ -655,14 +655,6 @@ Error Display::initialize()
    ASSERT(mImplementation != nullptr);
    mImplementation->setBlobCache(&mBlobCache);
-    // Enable shader caching if debug layers are turned on. This allows us to test that shaders are
-    // properly saved & restored on all platforms. The cache won't allocate space until it's used
-    // and will be ignored entirely if the application / system sets it's own cache functions.
-    if (rx::ShouldUseDebugLayers(mAttributeMap))
-    {
-        mBlobCache.resize(1024 * 1024);
-    }
    gl::InitializeDebugAnnotations(&mAnnotator);
    gl::InitializeDebugMutexIfNeeded();