Skip to content

A
angle
Commit 79de62c6 by Nico Weber Committed by Commit Bot
Options

Explicitly suppress -Wimplicit-fallthrough for angle and its deps.

No behavior change since that warning isn't enabled anywhere yet, and it's opt-in. This is a prerequisite for https://chromium-review.googlesource.com/c/chromium/src/+/895726 Bug: chromium:177475 Change-Id: Ie5ffccd240a65646fe07e7d4475f63c4e8620746 Reviewed-on: https://chromium-review.googlesource.com/895728Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
parent e13f7ebe
Showing with 26 additions and 5 deletions
BUILD.gn
...@@ -96,8 +96,13 @@ config("extra_warnings") { ...@@ -96,8 +96,13 @@ config("extra_warnings") {
] ]
} }
if (is_clang) { if (is_clang) {
# Remove when crbug.com/428099 is resolved. cflags += [
cflags += [ "-Winconsistent-missing-override" ] # Remove when crbug.com/428099 is resolved.
"-Winconsistent-missing-override",
# TODO(thakis): Consider enabling this, https://crbug.com/807632
"-Wno-implicit-fallthrough",
]
} }
} }
......
src/vulkan_support/BUILD.gn
...@@ -241,9 +241,14 @@ config("vulkan_internal_config") { ...@@ -241,9 +241,14 @@ config("vulkan_internal_config") {
if (is_clang || !is_win) { if (is_clang || !is_win) {
cflags = [ "-Wno-unused-function" ] cflags = [ "-Wno-unused-function" ]
# See https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1649 cflags += [
# TODO(jmadill): Lift this once github issue is fixed. # See https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1649
cflags += [ "-Wno-ignored-attributes" ] # TODO(jmadill): Lift this once github issue is fixed.
"-Wno-ignored-attributes",
# TODO(thakis): Consider enabling this, https://crbug.com/807632
"-Wno-implicit-fallthrough",
]
} }
if (is_linux) { if (is_linux) {
defines += [ defines += [
...@@ -475,6 +480,12 @@ config("spirv_tools_config") { ...@@ -475,6 +480,12 @@ config("spirv_tools_config") {
] ]
} }
} }
config("spirv_tools_internal_config") {
if (is_clang) {
# TODO(thakis): Consider enabling this, https://crbug.com/807632
cflags = [ "-Wno-implicit-fallthrough" ]
}
}
static_library("spirv_tools") { static_library("spirv_tools") {
deps = [ deps = [
...@@ -565,6 +576,7 @@ static_library("spirv_tools") { ...@@ -565,6 +576,7 @@ static_library("spirv_tools") {
"$spirv_tools_dir/source/validate_type_unique.cpp", "$spirv_tools_dir/source/validate_type_unique.cpp",
] ]
public_configs = [ ":spirv_tools_config" ] public_configs = [ ":spirv_tools_config" ]
configs += [ ":spirv_tools_internal_config" ]
foreach(target_name, spvtools_vendor_tables) { foreach(target_name, spvtools_vendor_tables) {
deps += [ ":$target_name" ] deps += [ ":$target_name" ]
...@@ -588,6 +600,10 @@ config("glslang_internal_config") { ...@@ -588,6 +600,10 @@ config("glslang_internal_config") {
"-Wno-reorder", "-Wno-reorder",
] ]
} }
if (is_clang) {
# TODO(thakis): Consider enabling this, https://crbug.com/807632
cflags += [ "-Wno-implicit-fallthrough" ]
}
} }
static_library("glslang") { static_library("glslang") {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment