Revert "Pass #pragma optimize setting down to compilation."

include/GLSLANG/ShaderLang.h

@@ -743,8 +743,6 @@ int GetGeometryShaderInvocations(const ShHandle handle);
 int GetGeometryShaderMaxVertices(const ShHandle handle);
 unsigned int GetShaderSharedMemorySize(const ShHandle handle);
 
-bool GetPragmaOptimize(const ShHandle handle);
-
 //
 // Helper function to identify specs that are based on the WebGL spec.
 //

src/compiler/translator/Compiler.cpp

@@ -1506,11 +1506,6 @@ bool TCompiler::isVaryingDefined(const char *varyingName)
     return false;
 }
 
-bool TCompiler::getPragmaOptimize() const
-{
-    return mPragma.optimize;
-}
-
 void EmitEarlyFragmentTestsGLSL(const TCompiler &compiler, TInfoSinkBase &sink)
 {
     if (compiler.isEarlyFragmentTestsSpecified() || compiler.isEarlyFragmentTestsOptimized())

src/compiler/translator/Compiler.h

@@ -144,14 +144,13 @@ class TCompiler : public TShHandleBase
         return mGeometryShaderOutputPrimitiveType;
     }
 
+    unsigned int getStructSize(const ShaderVariable &var) const;
     unsigned int getSharedMemorySize() const;
 
     sh::GLenum getShaderType() const { return mShaderType; }
 
     bool validateAST(TIntermNode *root);
 
-    bool getPragmaOptimize() const;
-
   protected:
     // Add emulated functions to the built-in function emulator.
     virtual void initBuiltInFunctionEmulator(BuiltInFunctionEmulator *emu,

src/compiler/translator/ShaderLang.cpp

@@ -716,17 +716,6 @@ unsigned int GetShaderSharedMemorySize(const ShHandle handle)
     return sharedMemorySize;
 }
 
-bool GetPragmaOptimize(const ShHandle handle)
-{
-    ASSERT(handle);
-
-    TShHandleBase *base = static_cast<TShHandleBase *>(handle);
-    TCompiler *compiler = base->getAsCompiler();
-    ASSERT(compiler);
-
-    return compiler->getPragmaOptimize();
-}
-
 // Can't prefix with just _ because then we might introduce a double underscore, which is not safe
 // in GLSL (ESSL 3.00.6 section 3.8: All identifiers containing a double underscore are reserved for
 // use by the underlying implementation). u is short for user-defined.

src/libANGLE/Program.cpp

@@ -1684,8 +1684,6 @@ void Program::updateLinkedShaderStages()
         if (shader)
         {
             mState.mExecutable->setLinkedShaderStages(shader->getType());
-            mState.mExecutable->mShaderOptimizationEnabled[shader->getType()] =
-                shader->getState().isOptimizationEnabled();
         }
     }
 

src/libANGLE/ProgramExecutable.cpp

@@ -147,8 +147,6 @@ void ProgramExecutable::load(gl::BinaryInputStream *stream)
     mLinkedComputeShaderStages  = ShaderBitSet(stream->readInt<uint8_t>());
     mIsCompute                  = stream->readBool();
 
-    mShaderOptimizationEnabled = ShaderBitSet(stream->readInt<uint8_t>());
-
     mPipelineHasGraphicsUniformBuffers       = stream->readBool();
     mPipelineHasComputeUniformBuffers        = stream->readBool();
     mPipelineHasGraphicsStorageBuffers       = stream->readBool();
@@ -174,8 +172,6 @@ void ProgramExecutable::save(gl::BinaryOutputStream *stream) const
     stream->writeInt(mLinkedComputeShaderStages.bits());
     stream->writeInt(static_cast<bool>(mIsCompute));
 
-    stream->writeInt(mShaderOptimizationEnabled.bits());
-
     stream->writeInt(static_cast<bool>(mPipelineHasGraphicsUniformBuffers));
     stream->writeInt(static_cast<bool>(mPipelineHasComputeUniformBuffers));
     stream->writeInt(static_cast<bool>(mPipelineHasGraphicsStorageBuffers));

src/libANGLE/ProgramExecutable.h

@@ -302,11 +302,6 @@ class ProgramExecutable final : public angle::Subject
     }
     int getLinkedShaderVersion(ShaderType shaderType) { return mLinkedShaderVersions[shaderType]; }
 
-    bool isShaderOptimizationEnabled(ShaderType shaderType) const
-    {
-        return mShaderOptimizationEnabled[shaderType];
-    }
-
   private:
     // TODO(timvp): http://anglebug.com/3570: Investigate removing these friend
     // class declarations and accessing the necessary members with getters/setters.
@@ -398,8 +393,6 @@ class ProgramExecutable final : public angle::Subject
 
     bool mIsCompute;
 
-    ShaderBitSet mShaderOptimizationEnabled;
-
     ShaderMap<std::vector<sh::ShaderVariable>> mLinkedOutputVaryings;
     ShaderMap<std::vector<sh::ShaderVariable>> mLinkedInputVaryings;
     ShaderMap<int> mLinkedShaderVersions;

src/libANGLE/ProgramPipeline.cpp

@@ -416,17 +416,6 @@ void ProgramPipeline::updateExecutable()
 
     // Must be last, since it queries things updated by earlier functions
     updateHasBooleans();
-
-    for (const gl::ShaderType shaderType : kAllGraphicsShaderTypes)
-    {
-        const Program *shaderProgram = getShaderProgram(shaderType);
-        if (shaderProgram)
-        {
-            const ProgramExecutable &executable = shaderProgram->getExecutable();
-            mState.mExecutable->mShaderOptimizationEnabled[shaderType] =
-                executable.isShaderOptimizationEnabled(shaderType);
-        }
-    }
 }
 
 ProgramMergedVaryings ProgramPipeline::getMergedVaryings() const

src/libANGLE/Shader.cpp

@@ -118,8 +118,6 @@ ShaderState::ShaderState(ShaderType shaderType)
     : mLabel(),
       mShaderType(shaderType),
       mShaderVersion(100),
-      mEarlyFragmentTestsOptimization(false),
-      mOptimizationEnabled(true),
       mNumViews(-1),
       mGeometryShaderInvocations(1),
       mCompileStatus(CompileStatus::NOT_COMPILED)
@@ -429,8 +427,7 @@ void Shader::resolveCompile()
 #endif  // !defined(NDEBUG)
 
     // Gather the shader information
-    mState.mShaderVersion       = sh::GetShaderVersion(compilerHandle);
-    mState.mOptimizationEnabled = sh::GetPragmaOptimize(compilerHandle);
+    mState.mShaderVersion = sh::GetShaderVersion(compilerHandle);
 
     mState.mUniforms            = GetShaderVariables(sh::GetUniforms(compilerHandle));
     mState.mUniformBlocks       = GetShaderVariables(sh::GetUniformBlocks(compilerHandle));

src/libANGLE/Shader.h

@@ -109,8 +109,6 @@ class ShaderState final : angle::NonCopyable
 
     CompileStatus getCompileStatus() const { return mCompileStatus; }
 
-    bool isOptimizationEnabled() const { return mOptimizationEnabled; }
-
   private:
     friend class Shader;
 
@@ -133,7 +131,6 @@ class ShaderState final : angle::NonCopyable
     std::vector<sh::ShaderVariable> mActiveOutputVariables;
 
     bool mEarlyFragmentTestsOptimization;
-    bool mOptimizationEnabled;
 
     // ANGLE_multiview.
     int mNumViews;

src/libANGLE/renderer/d3d/ShaderD3D.cpp

@@ -184,10 +184,6 @@ void ShaderD3D::generateWorkarounds(angle::CompilerWorkaroundsD3D *workarounds)
         // disabling optimization
         workarounds->skipOptimization = true;
     }
-    else if (!mState.isOptimizationEnabled())
-    {
-        workarounds->skipOptimization = true;
-    }
     else if (mUsesNestedBreak)
     {
         // ANGLE issue 603:

src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp

@@ -2994,8 +2994,7 @@ angle::Result Renderer11::compileToExecutable(d3d::Context *context,
                   << getShaderModelSuffix();
     std::string profile = profileStream.str();
 
-    UINT flags = workarounds.skipOptimization ? D3DCOMPILE_SKIP_OPTIMIZATION
-                                              : D3DCOMPILE_OPTIMIZATION_LEVEL2;
+    UINT flags = D3DCOMPILE_OPTIMIZATION_LEVEL2;
 
 #if defined(ANGLE_ENABLE_DEBUG_TRACE)
 #    ifndef NDEBUG

src/tests/gl_tests/GLSLTest.cpp

@@ -368,8 +368,7 @@ class GLSLTest : public ANGLETest
         std::stringstream fragmentShader;
 
         // Generate the vertex shader
-        vertexShader << "#pragma optimize(off)\n"
-                     << "precision mediump float;\n";
+        vertexShader << "precision mediump float;\n";
 
         for (int i = 0; i < vertexUniformCount; i++)
         {