Add a dotfile_settings GN config file.

This file will be imported into both ANGLE's and Chrome's .gn files so we can share some of the same settings. This will mean we no longer have to patch Chromium to make changes to the exec script whitelist. Bug: angleproject:2339 Change-Id: I2d7dd4237488ffecf5376643447ad95a0c1dbf98 Reviewed-on: https://chromium-review.googlesource.com/902324Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Add a dotfile_settings GN config file.
7b7ada6a · Jamie Madill · Commit Bot · 22294b04 · 7b7ada6a · 7b7ada6a
Commit 7b7ada6a authored Feb 05, 2018 by Jamie Madill Committed by Commit Bot Feb 05, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 41 additions and 28 deletions

.gn .gn +27 -28

dotfile_settings.gni dotfile_settings.gni +14 -0

No files found.
--- a/.gn
+++ b/.gn
@@ -7,6 +7,8 @@
 # As a result this file will only affect stand-alone ANGLE builds,
 # not chromium builds.

+import("//dotfile_settings.gni")
+
 # Location of the build configuration file.
 buildconfig = "//build/config/BUILDCONFIG.gn"

@@ -24,34 +26,31 @@ check_targets = []
 # These are the list of GN files that run exec_script. This whitelist exists
 # to force additional review for new uses of exec_script, which is strongly
 # discouraged except for gypi_to_gn calls.
-exec_script_whitelist = [
-  "//build/config/android/BUILD.gn",
-  "//build/config/android/config.gni",
-  "//build/config/android/internal_rules.gni",
-  "//build/config/android/rules.gni",
-  "//build/config/BUILD.gn",
-  "//build/config/compiler/BUILD.gn",
-  "//build/config/ios/ios_sdk.gni",
-  "//build/config/linux/atk/BUILD.gn",
-  "//build/config/linux/BUILD.gn",
-  "//build/config/linux/pkg_config.gni",
-  "//build/config/mac/mac_sdk.gni",
-  "//build/config/posix/BUILD.gn",
-  "//build/config/sysroot.gni",
-  "//build/config/win/BUILD.gn",
-  "//build/config/win/visual_studio_version.gni",
-  "//build/gn_helpers.py",
-  "//build/gypi_to_gn.py",
-  "//build/toolchain/concurrent_links.gni",
-  "//build/toolchain/gcc_toolchain.gni",
-  "//build/toolchain/mac/BUILD.gn",
-  "//build/toolchain/win/BUILD.gn",
-  "//build/util/branding.gni",
-  "//build/util/version.gni",
-  "//BUILD.gn",
-  "//src/tests/BUILD.gn",
-  "//src/vulkan_support/BUILD.gn",
-]
+exec_script_whitelist = angle_dotfile_settings.exec_script_whitelist + [
+                          "//build/config/android/BUILD.gn",
+                          "//build/config/android/config.gni",
+                          "//build/config/android/internal_rules.gni",
+                          "//build/config/android/rules.gni",
+                          "//build/config/BUILD.gn",
+                          "//build/config/compiler/BUILD.gn",
+                          "//build/config/ios/ios_sdk.gni",
+                          "//build/config/linux/atk/BUILD.gn",
+                          "//build/config/linux/BUILD.gn",
+                          "//build/config/linux/pkg_config.gni",
+                          "//build/config/mac/mac_sdk.gni",
+                          "//build/config/posix/BUILD.gn",
+                          "//build/config/sysroot.gni",
+                          "//build/config/win/BUILD.gn",
+                          "//build/config/win/visual_studio_version.gni",
+                          "//build/gn_helpers.py",
+                          "//build/gypi_to_gn.py",
+                          "//build/toolchain/concurrent_links.gni",
+                          "//build/toolchain/gcc_toolchain.gni",
+                          "//build/toolchain/mac/BUILD.gn",
+                          "//build/toolchain/win/BUILD.gn",
+                          "//build/util/branding.gni",
+                          "//build/util/version.gni",
+                        ]

 default_args = {
  use_custom_libcxx = false

--- a/dotfile_settings.gni
+++ b/dotfile_settings.gni
+# Copyright 2018 The ANGLE Project Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# This file contains variables that can be imported into a repo's dotfile (.gn)
+# to make it easier to roll new versions of ANGLE in.
+
+angle_dotfile_settings = {
+  exec_script_whitelist = [
+    get_path_info("BUILD.gn", "abspath"),
+    get_path_info("src/tests/BUILD.gn", "abspath"),
+    get_path_info("src/vulkan_support/BUILD.gn", "abspath"),
+  ]
+}