Fix a memory out-of-bound visit bug.

So len could equal = max_len, and at this point name[len] is out of the range. BUG= TEST= Review URL: https://codereview.appspot.com/7223045 git-svn-id: https://angleproject.googlecode.com/svn/trunk@1803 736b8ea6-26fd-11df-bfd4-992fa37f6226

Fix a memory out-of-bound visit bug.
7bc1d59f · zmo@google.com · 665dcdce · 7bc1d59f
Commit 7bc1d59f authored Jan 26, 2013 by zmo@google.com
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

ShaderLang.cpp src/compiler/ShaderLang.cpp +2 -2

No files found.
--- a/src/compiler/ShaderLang.cpp
+++ b/src/compiler/ShaderLang.cpp
@@ -334,7 +334,7 @@ void ShGetNameHashingEntry(const ShHandle handle,
    }
    strncpy(name, it->first.c_str(), len);
    // To be on the safe side in case the source is longer than expected.
-    name[len] = '\0';
+    name[len - 1] = '\0';
    len = it->second.length() + 1;
    max_len = 0;
@@ -345,5 +345,5 @@ void ShGetNameHashingEntry(const ShHandle handle,
    }
    strncpy(hashedName, it->second.c_str(), len);
    // To be on the safe side in case the source is longer than expected.
-    hashedName[len] = '\0';
+    hashedName[len - 1] = '\0';
 }