Commit 7cc1e556 by Jamie Madill Committed by Commit Bot

Don't use ErrorOrResult in VertexBuffer.h.

This enables the error refactor for D3D. Bug: angleproject:2752 Change-Id: I7bb293d6c271d0bffb4d00b55029426b6cd0a42e Reviewed-on: https://chromium-review.googlesource.com/1167208Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent c86c8b0c
...@@ -90,12 +90,12 @@ gl::Error VertexBufferInterface::setBufferSize(const gl::Context *context, unsig ...@@ -90,12 +90,12 @@ gl::Error VertexBufferInterface::setBufferSize(const gl::Context *context, unsig
return mVertexBuffer->setBufferSize(context, size); return mVertexBuffer->setBufferSize(context, size);
} }
gl::ErrorOrResult<unsigned int> VertexBufferInterface::getSpaceRequired( gl::Error VertexBufferInterface::getSpaceRequired(const gl::Context *context,
const gl::Context *context, const gl::VertexAttribute &attrib,
const gl::VertexAttribute &attrib, const gl::VertexBinding &binding,
const gl::VertexBinding &binding, size_t count,
size_t count, GLsizei instances,
GLsizei instances) const unsigned int *spaceInBytesOut) const
{ {
unsigned int spaceRequired = 0; unsigned int spaceRequired = 0;
ANGLE_TRY(mFactory->getVertexSpaceRequired(context, attrib, binding, count, instances, ANGLE_TRY(mFactory->getVertexSpaceRequired(context, attrib, binding, count, instances,
...@@ -110,7 +110,8 @@ gl::ErrorOrResult<unsigned int> VertexBufferInterface::getSpaceRequired( ...@@ -110,7 +110,8 @@ gl::ErrorOrResult<unsigned int> VertexBufferInterface::getSpaceRequired(
<< "Vertex buffer overflow in VertexBufferInterface::getSpaceRequired."; << "Vertex buffer overflow in VertexBufferInterface::getSpaceRequired.";
} }
return alignedSpaceRequired; *spaceInBytesOut = alignedSpaceRequired;
return gl::NoError();
} }
gl::Error VertexBufferInterface::discard(const gl::Context *context) gl::Error VertexBufferInterface::discard(const gl::Context *context)
...@@ -177,7 +178,7 @@ gl::Error StreamingVertexBufferInterface::storeDynamicAttribute(const gl::Contex ...@@ -177,7 +178,7 @@ gl::Error StreamingVertexBufferInterface::storeDynamicAttribute(const gl::Contex
const uint8_t *sourceData) const uint8_t *sourceData)
{ {
unsigned int spaceRequired = 0; unsigned int spaceRequired = 0;
ANGLE_TRY_RESULT(getSpaceRequired(context, attrib, binding, count, instances), spaceRequired); ANGLE_TRY(getSpaceRequired(context, attrib, binding, count, instances, &spaceRequired));
// Protect against integer overflow // Protect against integer overflow
angle::CheckedNumeric<unsigned int> checkedPosition(mWritePosition); angle::CheckedNumeric<unsigned int> checkedPosition(mWritePosition);
...@@ -297,7 +298,7 @@ gl::Error StaticVertexBufferInterface::storeStaticAttribute(const gl::Context *c ...@@ -297,7 +298,7 @@ gl::Error StaticVertexBufferInterface::storeStaticAttribute(const gl::Context *c
const uint8_t *sourceData) const uint8_t *sourceData)
{ {
unsigned int spaceRequired = 0; unsigned int spaceRequired = 0;
ANGLE_TRY_RESULT(getSpaceRequired(context, attrib, binding, count, instances), spaceRequired); ANGLE_TRY(getSpaceRequired(context, attrib, binding, count, instances, &spaceRequired));
ANGLE_TRY(setBufferSize(context, spaceRequired)); ANGLE_TRY(setBufferSize(context, spaceRequired));
ASSERT(attrib.enabled); ASSERT(attrib.enabled);
......
...@@ -95,11 +95,12 @@ class VertexBufferInterface : angle::NonCopyable ...@@ -95,11 +95,12 @@ class VertexBufferInterface : angle::NonCopyable
gl::Error setBufferSize(const gl::Context *context, unsigned int size); gl::Error setBufferSize(const gl::Context *context, unsigned int size);
gl::ErrorOrResult<unsigned int> getSpaceRequired(const gl::Context *context, gl::Error getSpaceRequired(const gl::Context *context,
const gl::VertexAttribute &attrib, const gl::VertexAttribute &attrib,
const gl::VertexBinding &binding, const gl::VertexBinding &binding,
size_t count, size_t count,
GLsizei instances) const; GLsizei instances,
unsigned int *spaceInBytesOut) const;
BufferFactoryD3D *const mFactory; BufferFactoryD3D *const mFactory;
VertexBuffer *mVertexBuffer; VertexBuffer *mVertexBuffer;
bool mDynamic; bool mDynamic;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment