Allow ReadPixels with GL_FLOAT type and EXT_color_buffer_half_float.

BUG=angleproject:2148 Change-Id: If3fa4a42a7343ed133f85be1a4d9d0fa48b427cd Reviewed-on: https://chromium-review.googlesource.com/665158Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Allow ReadPixels with GL_FLOAT type and EXT_color_buffer_half_float.
7d4602fc · Geoff Lang · Commit Bot · 715e7f1a · 7d4602fc · 7d4602fc
Commit 7d4602fc authored Sep 13, 2017 by Geoff Lang Committed by Commit Bot Sep 13, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

validationES.cpp src/libANGLE/validationES.cpp +2 -1

WebGLCompatibilityTest.cpp src/tests/gl_tests/WebGLCompatibilityTest.cpp +2 -2

No files found.
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -176,7 +176,8 @@ bool ValidReadPixelsTypeEnum(ValidationContext *context, GLenum type)
            return context->getClientVersion() >= ES_3_0;
        case GL_FLOAT:
-            return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat;
+            return context->getClientVersion() >= ES_3_0 || context->getExtensions().textureFloat ||
+                   context->getExtensions().colorBufferHalfFloat;
        case GL_HALF_FLOAT:
            return context->getClientVersion() >= ES_3_0 ||

--- a/src/tests/gl_tests/WebGLCompatibilityTest.cpp
+++ b/src/tests/gl_tests/WebGLCompatibilityTest.cpp
@@ -37,11 +37,11 @@ void CheckBlendFunctions(GLenum src, GLenum dst)
 constexpr const char *FloatingPointTextureExtensions[] = {
    "",
    "GL_EXT_texture_storage",
-    "GL_OES_texture_float",
-    "GL_OES_texture_float_linear",
    "GL_OES_texture_half_float",
    "GL_OES_texture_half_float_linear",
    "GL_EXT_color_buffer_half_float",
+    "GL_OES_texture_float",
+    "GL_OES_texture_float_linear",
    "GL_EXT_color_buffer_float",
    "GL_CHROMIUM_color_buffer_float_rgba",
    "GL_CHROMIUM_color_buffer_float_rgb",