Add helper function to pool allocate a char array

src/compiler/translator/Common.h

@@ -121,6 +121,17 @@ inline TString str(T i)
     return buffer;
 }
 
+// Allocate a char array in the global memory pool. str must be a null terminated string. strLength
+// is the length without the null terminator.
+inline const char *AllocatePoolCharArray(const char *str, size_t strLength)
+{
+    size_t requiredSize = strLength + 1;
+    char *buffer = reinterpret_cast<char *>(GetGlobalPoolAllocator()->allocate(requiredSize));
+    memcpy(buffer, str, requiredSize);
+    ASSERT(buffer[strLength] == 0);
+    return buffer;
+}
+
 }  // namespace sh
 
 namespace std

src/compiler/translator/Types.cpp

@@ -539,10 +539,7 @@ const char *TType::buildMangledName() const
     mangledName += ';';
 
     // Copy string contents into a pool-allocated buffer, so we never need to call delete.
-    size_t requiredSize = mangledName.size() + 1;
-    char *buffer = reinterpret_cast<char *>(GetGlobalPoolAllocator()->allocate(requiredSize));
-    memcpy(buffer, mangledName.c_str(), requiredSize);
-    return buffer;
+    return AllocatePoolCharArray(mangledName.c_str(), mangledName.size());
 }
 
 size_t TType::getObjectSize() const