Skip to content

A
angle
Commit 7f8b6e3f by Ian Elliott Committed by Commit Bot
Options

Vulkan: Add support for GL_IMAGE_FORMAT_COMPATIBILITY_TYPE

For some reason, this wasn't implemented when texture image load and store was implemented. Bug: angleproject:4311 Change-Id: I24c508660ad7eb3aa944601175803751b54ce0ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011324Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
parent 8075d3ed
Showing with 4 additions and 1 deletion
src/libANGLE/queryutils.cpp
...@@ -320,6 +320,9 @@ void QueryTexParameterBase(const Context *context, ...@@ -320,6 +320,9 @@ void QueryTexParameterBase(const Context *context,
*params = CastFromGLintStateValue<ParamType>( *params = CastFromGLintStateValue<ParamType>(
pname, texture->getImplementationColorReadType(context)); pname, texture->getImplementationColorReadType(context));
break; break;
case GL_IMAGE_FORMAT_COMPATIBILITY_TYPE:
*params = GL_IMAGE_FORMAT_COMPATIBILITY_BY_SIZE;
break;
default: default:
UNREACHABLE(); UNREACHABLE();
break; break;
......
src/libANGLE/validationES.cpp
...@@ -5290,6 +5290,7 @@ bool ValidateGetTexParameterBase(Context *context, ...@@ -5290,6 +5290,7 @@ bool ValidateGetTexParameterBase(Context *context,
break; break;
case GL_DEPTH_STENCIL_TEXTURE_MODE: case GL_DEPTH_STENCIL_TEXTURE_MODE:
case GL_IMAGE_FORMAT_COMPATIBILITY_TYPE:
if (context->getClientVersion() < Version(3, 1)) if (context->getClientVersion() < Version(3, 1))
{ {
context->validationError(GL_INVALID_ENUM, kEnumRequiresGLES31); context->validationError(GL_INVALID_ENUM, kEnumRequiresGLES31);
......
src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
...@@ -60,7 +60,6 @@ ...@@ -60,7 +60,6 @@
// Image related failures // Image related failures
4311 : KHR-GLES31.core.shader_image_load_store.basic-api-texParam = FAIL
4314 : KHR-GLES31.core.shader_image_load_store.basic-glsl-earlyFragTests = FAIL 4314 : KHR-GLES31.core.shader_image_load_store.basic-glsl-earlyFragTests = FAIL
4316 : KHR-GLES31.core.shader_image_load_store.negative-linkErrors = FAIL 4316 : KHR-GLES31.core.shader_image_load_store.negative-linkErrors = FAIL
4312 VULKAN : KHR-GLES31.core.shader_image_load_store.basic-glsl-misc-fs = SKIP 4312 VULKAN : KHR-GLES31.core.shader_image_load_store.basic-glsl-misc-fs = SKIP
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment