Avoid vector copy in BinaryOutputStream::writeIntVector

src/libANGLE/BinaryStream.h

@@ -206,7 +206,7 @@ class BinaryOutputStream : angle::NonCopyable
     }
 
     template <class IntT>
-    void writeIntVector(std::vector<IntT> param)
+    void writeIntVector(const std::vector<IntT> &param)
     {
         writeInt(param.size());
         for (IntT element : param)

src/libANGLE/BinaryStream_unittest.cpp

@@ -65,4 +65,24 @@ TEST(BinaryInputStream, Overflow)
         stream.readBytes(outputData.data(), std::numeric_limits<size_t>::max() - dataSize - 2);
     }
 }
+
+// Test that readIntVector and writeIntVector match.
+TEST(BinaryStream, IntVector)
+{
+    std::vector<unsigned int> writeData = {1, 2, 3, 4, 5};
+    std::vector<unsigned int> readData;
+
+    gl::BinaryOutputStream out;
+    out.writeIntVector(writeData);
+
+    gl::BinaryInputStream in(out.data(), out.length());
+    in.readIntVector<unsigned int>(&readData);
+
+    ASSERT_EQ(writeData.size(), readData.size());
+
+    for (size_t i = 0; i < writeData.size(); ++i)
+    {
+        ASSERT_EQ(writeData[i], readData[i]);
+    }
+}
 }  // namespace angle