Vulkan: Recycle VkFence in checkCommandsCompleted

VkFence is intended to be recycled after used up, however, there is one place that VkFence get destroyed directly after usage due to an implementation flaw. This CL fixed it up. Bug: angleproject:3556 Change-Id: I9ee44556329b9cee39ccdfef540f3c1b5180cd36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731575Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tobin Ehlis <tobine@google.com>

Vulkan: Recycle VkFence in checkCommandsCompleted
82523300 · Jiacheng Lu · Commit Bot · 017c9d8e · 82523300
Commit 82523300 authored Aug 01, 2019 by Jiacheng Lu Committed by Commit Bot Aug 02, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

ContextVk.cpp src/libANGLE/renderer/vulkan/ContextVk.cpp +2 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/ContextVk.cpp
+++ b/src/libANGLE/renderer/vulkan/ContextVk.cpp
@@ -2341,7 +2341,7 @@ angle::Result ContextVk::checkCompletedCommands()
        ASSERT(batch.serial > mLastCompletedQueueSerial);
        mLastCompletedQueueSerial = batch.serial;

-        batch.fence.reset(device);
+        mRenderer->resetSharedFence(&batch.fence);
        ANGLE_TRACE_EVENT0("gpu.angle", "commandPool.destroy");
        batch.commandPool.destroy(device);
        ++finishedCount;
@@ -2437,7 +2437,7 @@ angle::Result ContextVk::getNextSubmitFence(vk::Shared<vk::Fence> *sharedFenceOu
    {
        ANGLE_TRY(getRenderer()->newSharedFence(this, &mSubmitFence));
    }
-    getRenderer()->resetSharedFence(sharedFenceOut);
+    ASSERT(!sharedFenceOut->isReferenced());
    sharedFenceOut->copy(getDevice(), mSubmitFence);
    return angle::Result::Continue;
 }