Commit 82830ede by Eric Engestrom Committed by Commit Bot

Fix assert in EGLSyncControlTest

`ust`, `ust2`, `msc`, and `msc2` are unsigned, so their difference is still unsigned. The `>0` assert could never fail. Fix this by simplifying the test to compare the pairs of values directly. Fixes: 5d9f5df0 ("Implementation of eglGetSyncValuesCHROMIUM extension.") Fixes: ee218f27 ("Re-land eglGetSyncValuesCHROMIUM extension.") Signed-off-by: 's avatarEric Engestrom <eric.engestrom@imgtec.com> Change-Id: I0b19d786720f545c846640d48c30a83a1d001396 Reviewed-on: https://chromium-review.googlesource.com/500189Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 8d835fba
...@@ -260,6 +260,6 @@ TEST_F(EGLSyncControlTest, DISABLED_SyncValuesTest) ...@@ -260,6 +260,6 @@ TEST_F(EGLSyncControlTest, DISABLED_SyncValuesTest)
// sbc2 should be 2. msc2 and ust2 should be greater than previous msc and ust values. // sbc2 should be 2. msc2 and ust2 should be greater than previous msc and ust values.
ASSERT_EQ(2ull, sbc2); ASSERT_EQ(2ull, sbc2);
ASSERT_GT((ust2 - ust), 0ull); ASSERT_GT(ust2, ust);
ASSERT_GT((msc2 - msc), 0ull); ASSERT_GT(msc2, msc);
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment