Skip to content

A
angle
Commit 82f2cf31 by James Darpinian Committed by Commit Bot
Options

Require DEBUG_TRACE to enable expensive state validation

ANGLE_STATE_VALIDATION_ENABLED is expensive, adding a lot of overhead to draw calls in debug mode. It's causing some of WebKit's layout tests to time out. Instead of enabling it for all debug builds, let's only enable it when ANGLE_ENABLE_DEBUG_TRACE is specified. Bug: angleproject:3900 Change-Id: I9866d7afbb5666f35c56539820d591953bdf7650 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1994440Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
parent 51179335
Showing with 1 addition and 1 deletion
src/common/debug.h
...@@ -254,7 +254,7 @@ std::ostream &FmtHex(std::ostream &os, T value) ...@@ -254,7 +254,7 @@ std::ostream &FmtHex(std::ostream &os, T value)
#endif #endif
// The state tracked by ANGLE will be validated with the driver state before each call // The state tracked by ANGLE will be validated with the driver state before each call
#if defined(ANGLE_ENABLE_ASSERTS) #if defined(ANGLE_ENABLE_DEBUG_TRACE)
# define ANGLE_STATE_VALIDATION_ENABLED # define ANGLE_STATE_VALIDATION_ENABLED
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment