Call ImageImpl::destroy before destroying the image source.

egl::Image destroys the source sibling before calling the backend destroy function. ImageVk needs the source image to do proper clean up. BUG=angleproject:3722 Change-Id: I110d77a9c4151166624bb953c579102ac7dab6ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1709752Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Call ImageImpl::destroy before destroying the image source.
833bce72 · Geoff Lang · Commit Bot · 610f2388 · 833bce72
Commit 833bce72 authored Jul 19, 2019 by Geoff Lang Committed by Commit Bot Jul 19, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

Image.cpp src/libANGLE/Image.cpp +3 -2

No files found.
--- a/src/libANGLE/Image.cpp
+++ b/src/libANGLE/Image.cpp
@@ -251,6 +251,9 @@ void Image::onDestroy(const Display *display)
    // no siblings left.
    ASSERT(mState.targets.empty());

+    // Make sure the implementation gets a chance to clean up before we delete the source.
+    mImplementation->onDestroy(display);
+
    // Tell the source that it is no longer used by this image
    if (mState.source != nullptr)
    {
@@ -266,8 +269,6 @@ void Image::onDestroy(const Display *display)

        mState.source = nullptr;
    }
-
-    mImplementation->onDestroy(display);
 }

 Image::~Image()