Vulkan: glDeleteTexture unbind all image texture units

The old code only unbound one image unit when a texture was deleted. The GLES specification is clear that the texture should be unbound from all units: If a texture object bound to one or more image units is deleted by DeleteTextures, it is detached from each such image unit, as though BindImageTexture were called with unit identifying the image unit and texture set to zero. Bug: angleproject:4310 Change-Id: I24c508660ad7eb3aa944601175803751b54ce0dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2011322Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>

Vulkan: glDeleteTexture unbind all image texture units
845a09b8 · Ian Elliott · Commit Bot · 62475e95 · 845a09b8 · 845a09b8
Commit 845a09b8 authored Jan 20, 2020 by Ian Elliott Committed by Commit Bot Jan 20, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

State.cpp src/libANGLE/State.cpp +0 -1

deqp_khr_gles31_test_expectations.txt src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt +0 -1

No files found.
--- a/src/libANGLE/State.cpp
+++ b/src/libANGLE/State.cpp
@@ -1232,7 +1232,6 @@ void State::detachTexture(const Context *context, const TextureMap &zeroTextures
            bindingImageUnit.layer   = 0;
            bindingImageUnit.access  = GL_READ_ONLY;
            bindingImageUnit.format  = GL_R32UI;
-            break;
        }
    }


--- a/src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
+++ b/src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
@@ -60,7 +60,6 @@

 // Image related failures

-4310 : KHR-GLES31.core.shader_image_load_store.basic-api-bind = FAIL
 4311 : KHR-GLES31.core.shader_image_load_store.basic-api-texParam = FAIL
 4314 : KHR-GLES31.core.shader_image_load_store.basic-glsl-earlyFragTests = FAIL
 4316 : KHR-GLES31.core.shader_image_load_store.negative-linkErrors = FAIL