Skip to content

A
angle
Commit 84a32193 by Tim Van Patten Committed by Commit Bot
Options

Vulkan: Disable Line Rasterization Emulation for Android

The latest Pixel drivers require that the GL line raserization emulation is disabled to rasterize the lines correctly. Bug: angleproject:2830 Test: dEQP-GLES2.functional.rasterization.primitives.line* Test: dEQP-GLES2.functional.clipping.line.long_line_clip Change-Id: I126715e61f44500c00efc7e81044c0a09001d3bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1812177Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
parent ce24932d
Showing with 6 additions and 6 deletions
src/libANGLE/renderer/vulkan/RendererVk.cpp
...@@ -1234,7 +1234,12 @@ gl::Version RendererVk::getMaxConformantESVersion() const ...@@ -1234,7 +1234,12 @@ gl::Version RendererVk::getMaxConformantESVersion() const
void RendererVk::initFeatures(const ExtensionNameList &deviceExtensionNames) void RendererVk::initFeatures(const ExtensionNameList &deviceExtensionNames)
{ {
// Use OpenGL line rasterization rules by default. // Use OpenGL line rasterization rules by default.
// TODO(jmadill): Fix Android support. http://anglebug.com/2830
#if defined(ANGLE_PLATFORM_ANDROID)
mFeatures.basicGLLineRasterization.enabled = false;
#else
mFeatures.basicGLLineRasterization.enabled = true; mFeatures.basicGLLineRasterization.enabled = true;
#endif // defined(ANGLE_PLATFORM_ANDROID)
if ((mPhysicalDeviceProperties.apiVersion >= VK_MAKE_VERSION(1, 1, 0)) || if ((mPhysicalDeviceProperties.apiVersion >= VK_MAKE_VERSION(1, 1, 0)) ||
ExtensionFound(VK_KHR_MAINTENANCE1_EXTENSION_NAME, deviceExtensionNames)) ExtensionFound(VK_KHR_MAINTENANCE1_EXTENSION_NAME, deviceExtensionNames))
......
src/tests/deqp_support/deqp_gles2_test_expectations.txt
...@@ -309,7 +309,6 @@ ...@@ -309,7 +309,6 @@
2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.line_loop = FAIL 2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.line_loop = FAIL
2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.line_strip = FAIL 2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.line_strip = FAIL
2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.lines = FAIL 2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.lines = FAIL
2830 VULKAN ANDROID : dEQP-GLES2.functional.clipping.line.long_line_clip = FAIL
// Failing on the Pixel 2. // Failing on the Pixel 2.
2808 VULKAN ANDROID : dEQP-GLES2.functional.shaders.builtin_variable.fragcoord_w = FAIL 2808 VULKAN ANDROID : dEQP-GLES2.functional.shaders.builtin_variable.fragcoord_w = FAIL
...@@ -382,4 +381,4 @@ ...@@ -382,4 +381,4 @@
// Failures on newer NVIDIA drivers (411.95) and passes on older drivers (388.16). // Failures on newer NVIDIA drivers (411.95) and passes on older drivers (388.16).
2976 VULKAN NVIDIA : dEQP-GLES2.functional.shaders.invariance.* = FAIL 2976 VULKAN NVIDIA : dEQP-GLES2.functional.shaders.invariance.* = FAIL
// Fails on 431.02 NVIDIA driver // Fails on 431.02 NVIDIA driver
3748 VULKAN WIN NVIDIA : dEQP-GLES2.functional.fbo.render.repeated_clear.* = FAIL 3748 VULKAN WIN NVIDIA : dEQP-GLES2.functional.fbo.render.repeated_clear.* = FAIL
\ No newline at end of file
src/tests/deqp_support/deqp_gles3_test_expectations.txt
...@@ -580,9 +580,6 @@ ...@@ -580,9 +580,6 @@
2672 VULKAN : dEQP-GLES3.functional.draw.draw_elements_instanced.line_loop.* = SKIP 2672 VULKAN : dEQP-GLES3.functional.draw.draw_elements_instanced.line_loop.* = SKIP
2672 VULKAN : dEQP-GLES3.functional.draw.random.* = SKIP 2672 VULKAN : dEQP-GLES3.functional.draw.random.* = SKIP
// Fails after OpenGL line rasterization rules implementation. Possibly a bug in FragCoord.
2830 VULKAN ANDROID : dEQP-GLES3.functional.clipping.line.long_line_clip = FAIL
// Base/Max levels: // Base/Max levels:
3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_2d_texture_base_level_gettexparameter* = SKIP 3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_2d_texture_base_level_gettexparameter* = SKIP
3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_3d_texture_base_level_gettexparameter* = SKIP 3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_3d_texture_base_level_gettexparameter* = SKIP
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment