Handle null ProgramExecutable in ValidateDrawInstancedANGLE()

It's possible for a user to call glDrawArraysInstancedANGLE() without a Program or PPO bound, which would lead to no ProgramExecutable being active and causes a null pointer to be returned in ValidateDrawInstancedANGLE(). To handle this, ValidateDrawInstancedANGLE() should return 'true' and not signal an error since it's undefined behavior to draw without a Program/PPO bound, but it's not an error. Bug: chromium:1079336 Test: gpu_angle_passthrough_fuzzer Change-Id: I90d9e99c63411d8388f4d8cf57ed46aec605ee68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197943 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com>

Handle null ProgramExecutable in ValidateDrawInstancedANGLE()
85c86567 · Tim Van Patten · Commit Bot · 66d7490c · 85c86567
Commit 85c86567 authored May 12, 2020 by Tim Van Patten Committed by Commit Bot May 15, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 0 deletions

validationES.cpp src/libANGLE/validationES.cpp +10 -0

No files found.
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -757,6 +757,16 @@ bool ValidateDrawInstancedANGLE(const Context *context)
    const State &state                  = context->getState();
    const ProgramExecutable *executable = state.getProgramExecutable();
+    if (!executable)
+    {
+        // No executable means there is no Program/PPO bound, which is undefined behavior, but isn't
+        // an error.
+        context->getState().getDebug().insertMessage(
+            GL_DEBUG_SOURCE_API, GL_DEBUG_TYPE_UNDEFINED_BEHAVIOR, 0, GL_DEBUG_SEVERITY_HIGH,
+            std::string("Attempting to draw without a program"), gl::LOG_WARN);
+        return true;
+    }
    const auto &attribs  = state.getVertexArray()->getVertexAttributes();
    const auto &bindings = state.getVertexArray()->getVertexBindings();
    for (size_t attributeIndex = 0; attributeIndex < MAX_VERTEX_ATTRIBS; attributeIndex++)