Vulkan: Build validation layers with asserts only

Adding ANGLE to the build includes the validation layers, which are only for development. We don't want any development or debugging code to be included by default in release builds, so tie building the validation layers to enablement of asserts. Bug: angleproject:2475 Test: gn gen out/fuchsia_rel --args='target_os="fuchsia" is_debug=false use_goma=true' gn desc out/fuchsia_rel //fuchsia/engine:web_engine runtime_deps Change-Id: I6d195c680255dcbc81e95f8e6f80e1e8ace169a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1656306Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org>

Vulkan: Build validation layers with asserts only
85fef1bc · Michael Spang · Commit Bot · ebddd1a2 · 85fef1bc
Commit 85fef1bc authored Jun 12, 2019 by Michael Spang Committed by Commit Bot Jun 13, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

angle.gni gni/angle.gni +2 -1

No files found.
--- a/gni/angle.gni
+++ b/gni/angle.gni
@@ -77,7 +77,8 @@ declare_args() {

  # Disable the layers in ubsan builds because of really slow builds.
  angle_enable_vulkan_validation_layers =
-      angle_enable_vulkan && !is_ubsan && !is_tsan && !is_asan
+      angle_enable_vulkan && !is_ubsan && !is_tsan && !is_asan &&
+      (is_debug || dcheck_always_on)

  if (angle_enable_vulkan) {
    # Enable Vulkan GPU trace event capability