Fix device removed handling for systems which do not

src/libGLESv2/renderer/d3d9/Renderer9.cpp

@@ -2153,7 +2153,7 @@ bool Renderer9::testDeviceResettable()
         return (mDeviceEx != NULL);
       case D3DERR_DEVICEREMOVED:
         ASSERT(mDeviceEx != NULL);
-        return true;
+        return isRemovedDeviceResettable();
       default:
         return false;
     }
@@ -2167,23 +2167,26 @@ bool Renderer9::resetDevice()
 
     HRESULT result = D3D_OK;
     bool lost = testDeviceLost(false);
-    int attempts = 3;
     bool removedDevice = (getDeviceStatusCode() == D3DERR_DEVICEREMOVED);
 
-    while (lost && attempts > 0)
+    // Device Removed is a feature which is only present with D3D9Ex
+    ASSERT(mDeviceEx != NULL || !removedDevice);
+
+    for (int attempts = 3; lost && attempts > 0; attempts--)
     {
-        if (mDeviceEx)
+        if (removedDevice)
+        {
+            // Device removed, which may trigger on driver reinstallation,
+            // may cause a longer wait other reset attempts before the
+            // system is ready to handle creating a new device.
+            Sleep(800);
+            lost = !resetRemovedDevice();
+        }
+        else if (mDeviceEx)
         {
             Sleep(500);   // Give the graphics driver some CPU time
-
-            if (removedDevice)
-            {
-                result = resetRemovedDevice();
-            }
-            else
-            {
-                result = mDeviceEx->ResetEx(&presentParameters, NULL);
-            }
+            result = mDeviceEx->ResetEx(&presentParameters, NULL);
+            lost = testDeviceLost(false);
         }
         else
         {
@@ -2198,10 +2201,8 @@ bool Renderer9::resetDevice()
             {
                 result = mDevice->Reset(&presentParameters);
             }
+            lost = testDeviceLost(false);
         }
-
-        lost = testDeviceLost(false);
-        attempts --;
     }
 
     if (FAILED(result))
@@ -2210,6 +2211,12 @@ bool Renderer9::resetDevice()
         return false;
     }
 
+    if (removedDevice && lost)
+    {
+        ERR("Device lost reset failed multiple times");
+        return false;
+    }
+
     // If the device was removed, we already finished re-initialization in resetRemovedDevice
     if (!removedDevice)
     {
@@ -2222,15 +2229,38 @@ bool Renderer9::resetDevice()
     return true;
 }
 
-HRESULT Renderer9::resetRemovedDevice()
+bool Renderer9::isRemovedDeviceResettable() const
+{
+    bool success = false;
+
+#ifdef ANGLE_ENABLE_D3D9EX
+    IDirect3D9Ex *d3d9Ex = NULL;
+    typedef HRESULT (WINAPI *Direct3DCreate9ExFunc)(UINT, IDirect3D9Ex**);
+    Direct3DCreate9ExFunc Direct3DCreate9ExPtr = reinterpret_cast<Direct3DCreate9ExFunc>(GetProcAddress(mD3d9Module, "Direct3DCreate9Ex"));
+
+    if (Direct3DCreate9ExPtr && SUCCEEDED(Direct3DCreate9ExPtr(D3D_SDK_VERSION, &d3d9Ex)))
+    {
+        D3DCAPS9 deviceCaps;
+        HRESULT result = d3d9Ex->GetDeviceCaps(mAdapter, mDeviceType, &deviceCaps);
+        success = SUCCEEDED(result);
+    }
+
+    SafeRelease(d3d9Ex);
+#else
+    ASSERT(UNREACHABLE());
+#endif
+
+    return success;
+}
+
+bool Renderer9::resetRemovedDevice()
 {
     // From http://msdn.microsoft.com/en-us/library/windows/desktop/bb172554(v=vs.85).aspx:
     // The hardware adapter has been removed. Application must destroy the device, do enumeration of
     // adapters and create another Direct3D device. If application continues rendering without
     // calling Reset, the rendering calls will succeed. Applies to Direct3D 9Ex only.
-    ASSERT(mDeviceEx != NULL);
     deinitialize();
-    return (initialize() == EGL_SUCCESS ? S_OK : S_FALSE);
+    return (initialize() == EGL_SUCCESS);
 }
 
 DWORD Renderer9::getAdapterVendor() const

src/libGLESv2/renderer/d3d9/Renderer9.h

@@ -256,7 +256,8 @@ class Renderer9 : public Renderer
     void releaseDeviceResources();
 
     HRESULT getDeviceStatusCode();
-    HRESULT resetRemovedDevice();
+    bool isRemovedDeviceResettable() const;
+    bool resetRemovedDevice();
 
     UINT mAdapter;
     D3DDEVTYPE mDeviceType;