Vulkan: Add feature flag to fallback rotation to use driver uniform

include/platform/FeaturesVk.h

@@ -447,6 +447,13 @@ struct FeaturesVk : FeatureSetBase
     Feature emulatedPrerotation270 = {"emulatedPrerotation270", FeatureCategory::VulkanFeatures,
                                       "Emulate 270-degree prerotation.", &members,
                                       "http://anglebug.com/4901"};
+
+    // Whether we should use driver uniforms over specialization constants for some shader
+    // modifications like yflip and rotation.
+    Feature forceDriverUniformOverSpecConst = {
+        "forceDriverUniformOverSpecConst", FeatureCategory::VulkanWorkarounds,
+        "Forces using driver uniforms instead of specialization constants.", &members,
+        "http://issuetracker.google.com/173636783"};
 };
 
 inline FeaturesVk::FeaturesVk()  = default;

src/libANGLE/renderer/vulkan/RendererVk.cpp

@@ -1738,7 +1738,8 @@ void RendererVk::initFeatures(DisplayVk *displayVk,
         return;
     }
 
-    constexpr uint32_t kPixel2DriverWithRelaxedPrecision = 0x801EA000;
+    constexpr uint32_t kPixel2DriverWithRelaxedPrecision        = 0x801EA000;
+    constexpr uint32_t kPixel4DriverWithWorkingSpecConstSupport = 0x80201000;
 
     bool isAMD      = IsAMD(mPhysicalDeviceProperties.vendorID);
     bool isIntel    = IsIntel(mPhysicalDeviceProperties.vendorID);
@@ -1953,6 +1954,12 @@ void RendererVk::initFeatures(DisplayVk *displayVk,
     ANGLE_FEATURE_CONDITION(&mFeatures, supportsShaderImageFloat32Atomics,
                             mShaderAtomicFloatFeature.shaderImageFloat32Atomics == VK_TRUE);
 
+    // http://issuetracker.google.com/173636783 Qualcomm driver appears having issues with
+    // specialization constant
+    ANGLE_FEATURE_CONDITION(&mFeatures, forceDriverUniformOverSpecConst,
+                            isQualcomm && mPhysicalDeviceProperties.driverVersion <
+                                              kPixel4DriverWithWorkingSpecConstSupport);
+
     // The compute shader used to generate mipmaps uses a 256-wide workgroup.  This path is only
     // enabled on devices that meet this minimum requirement.  Furthermore,
     // VK_IMAGE_USAGE_STORAGE_BIT is detrimental to performance on many platforms, on which this

src/libANGLE/renderer/vulkan/ShaderVk.cpp

@@ -73,7 +73,10 @@ std::shared_ptr<WaitableCompileEvent> ShaderVk::compile(const gl::Context *conte
     compileOptions |= SH_EARLY_FRAGMENT_TESTS_OPTIMIZATION;
 
     // Let compiler use specialized constant for pre-rotation.
-    compileOptions |= SH_USE_ROTATION_SPECIALIZATION_CONSTANT;
+    if (!contextVk->getFeatures().forceDriverUniformOverSpecConst.enabled)
+    {
+        compileOptions |= SH_USE_ROTATION_SPECIALIZATION_CONSTANT;
+    }
 
     if (contextVk->getFeatures().enablePreRotateSurfaces.enabled ||
         contextVk->getFeatures().emulatedPrerotation90.enabled ||