Commit 8ac49e18 by Tim Van Patten Committed by Commit Bot

Fix dEQP renderbuffer unspecified attachment test.

The spec mandates default sizes of 0 for everything, while we assume a non-initialized Renderbuffer is RGBA4. Bug: angleproject:2321 Test: dEQP-GLES3.functional.state_query.fbo.framebuffer_unspecified_attachment_x_size_rbo Change-Id: I7defbdda46fc90dc3672628667c710a8304473b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1785881Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
parent d9456b25
......@@ -140,32 +140,32 @@ void FramebufferAttachment::attach(const Context *context,
GLuint FramebufferAttachment::getRedSize() const
{
return getFormat().info->redBits;
return getSize().empty() ? 0 : getFormat().info->redBits;
}
GLuint FramebufferAttachment::getGreenSize() const
{
return getFormat().info->greenBits;
return getSize().empty() ? 0 : getFormat().info->greenBits;
}
GLuint FramebufferAttachment::getBlueSize() const
{
return getFormat().info->blueBits;
return getSize().empty() ? 0 : getFormat().info->blueBits;
}
GLuint FramebufferAttachment::getAlphaSize() const
{
return getFormat().info->alphaBits;
return getSize().empty() ? 0 : getFormat().info->alphaBits;
}
GLuint FramebufferAttachment::getDepthSize() const
{
return getFormat().info->depthBits;
return getSize().empty() ? 0 : getFormat().info->depthBits;
}
GLuint FramebufferAttachment::getStencilSize() const
{
return getFormat().info->stencilBits;
return getSize().empty() ? 0 : getFormat().info->stencilBits;
}
GLenum FramebufferAttachment::getComponentType() const
......
......@@ -32,10 +32,6 @@
// Don't run these tests for faster turnover
1101 : dEQP-GLES3.functional.flush_finish.* = SKIP
// Figure out why this caused this regression in Chrome:
// https://bugs.chromium.org/p/chromium/issues/detail?id=833809#
2321 : dEQP-GLES3.functional.state_query.fbo.framebuffer_unspecified_attachment_x_size_rbo = FAIL
// TODO(jmadill): Figure out why these fail on the bots, but not locally.
1108 WIN D3D11 : dEQP-GLES3.functional.shaders.struct.local.dynamic_loop_struct_array_fragment = FAIL
1094 WIN D3D11 : dEQP-GLES3.functional.shaders.invariance.highp.loop_2 = FAIL
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment