FramebufferAttachment: Cast pointers directly.

Instead of using a temporary pointer-to-pointer, try casting the pointer-to-pointer type directly. This will facilitate Vulkan's use of RenderTargets. BUG=angleproject:1319 Change-Id: I0a14762e8e442b9eaa6eba3fdf653aef3c362533 Reviewed-on: https://chromium-review.googlesource.com/424148Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

FramebufferAttachment: Cast pointers directly.
8aee6546 · Jamie Madill · Commit Bot · 4d0bf557 · 8aee6546
Commit 8aee6546 authored Jan 02, 2017 by Jamie Madill Committed by Commit Bot Jan 02, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

FramebufferAttachment.h src/libANGLE/FramebufferAttachment.h +3 -5

No files found.
--- a/src/libANGLE/FramebufferAttachment.h
+++ b/src/libANGLE/FramebufferAttachment.h
@@ -131,11 +131,9 @@ class FramebufferAttachment final
    template <typename T>
    gl::Error getRenderTarget(T **rtOut) const
    {
-        // Cast through the pointer-to-pointer type
+        static_assert(std::is_base_of<rx::FramebufferAttachmentRenderTarget, T>(),
-        rx::FramebufferAttachmentRenderTarget *rtPtr = nullptr;
+                      "Invalid RenderTarget class.");
-        gl::Error error = getRenderTarget(&rtPtr);
+        return getRenderTarget(reinterpret_cast<rx::FramebufferAttachmentRenderTarget **>(rtOut));
-        *rtOut = static_cast<T*>(rtPtr);
-        return error;
    }
    bool operator==(const FramebufferAttachment &other) const;