Generate an INVALID_OPERATION error if a texture format is not supported.

We already generate an INVALID_VALUE in the ValidES3InternalFormat check above. If an error is generated here, it is because the internal format and type are not valid. TEST: conformance2/textures/misc/tex-image-with-bad-args BUG=angleproject:1958 BUG=angleproject:1715 Change-Id: I50d479e64d687cc971c8f41b5691dcb123da0391 Reviewed-on: https://chromium-review.googlesource.com/499690Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>

Generate an INVALID_OPERATION error if a texture format is not supported.
8ceaedf8 · Geoff Lang · Commit Bot · 65ac5b9c · 8ceaedf8
Commit 8ceaedf8 authored May 09, 2017 by Geoff Lang Committed by Commit Bot May 10, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

validationES3.cpp src/libANGLE/validationES3.cpp +1 -1

No files found.
--- a/src/libANGLE/validationES3.cpp
+++ b/src/libANGLE/validationES3.cpp
@@ -78,7 +78,7 @@ static bool ValidateTexImageFormatCombination(gl::Context *context,
    const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalFormat, type);
    if (!formatInfo.textureSupport(context->getClientVersion(), context->getExtensions()))
    {
-        context->handleError(Error(GL_INVALID_VALUE, "Unsupported internal format."));
+        context->handleError(Error(GL_INVALID_OPERATION, "Unsupported internal format."));
        return false;
    }